[receiver/receivercreator] Add support for k8s service discovery #29022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
approved these changes
Nov 8, 2023
* main: [receiver/dockerstats] rename struct and function to keep expected receiver.Factory and pass checkapi (open-telemetry#27086) [all][chore] Moved from interface{} to any for all go code (open-telemetry#29072) [chore] bump go versions in workflows to 1.20.11 and 1.21.4 (open-telemetry#29080) hostmetricsreceiver: remove unused function (open-telemetry#29075) [exporter/influxdb] Remove //nolint indent-error-flow (open-telemetry#29073) [chore] dependabot updates Wed Nov 8 21:01:03 UTC 2023 (open-telemetry#29071) [chore] dependabot updates Wed Nov 8 18:29:02 UTC 2023 (open-telemetry#29052) [chore] dependabot updates Wed Nov 8 16:58:54 UTC 2023 (open-telemetry#29028) [receiver/collectd] move collectdreceiver to beta (open-telemetry#28997) [chore] update affiliation (open-telemetry#29019) Codesmon/exporter/azuremonitor/persistent queue (open-telemetry#26258) # Conflicts: # extension/observer/k8sobserver/handler.go
a-thaler
changed the title
|
Fixed all problems reported by the github actions, requires another run now. |
atoulme
reviewed
Nov 15, 2023
Co-authored-by: Antoine Toulme <antoine@toulme.name>
atoulme
added
the
ready to merge
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
…n-telemetry#29022) **Description:** - Added a new watch to the k8s_observer extension for k8s services, which can be enabled using a new flag "observe_services". - Discovered entities are transformed into a new endpoint type `k8s.service`. - Adjusted the receivercreator to support the new type `k8s.service` **Link to tracking Issue:** [open-telemetry#29021](open-telemetry#29021) **Testing:** Added unit tests analogue to the available tests **Documentation:** Adjusted readme's of k8s_observer and receivercreator. Added description of new flags and typers. **Note:** Current implementation is working as described in the linked ticket. Please check the potential discussion points mentioned in the ticket: open-telemetry#29021 (comment) --------- Co-authored-by: Antoine Toulme <antoine@toulme.name>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…n-telemetry#29022) **Description:** - Added a new watch to the k8s_observer extension for k8s services, which can be enabled using a new flag "observe_services". - Discovered entities are transformed into a new endpoint type `k8s.service`. - Adjusted the receivercreator to support the new type `k8s.service` **Link to tracking Issue:** [open-telemetry#29021](open-telemetry#29021) **Testing:** Added unit tests analogue to the available tests **Documentation:** Adjusted readme's of k8s_observer and receivercreator. Added description of new flags and typers. **Note:** Current implementation is working as described in the linked ticket. Please check the potential discussion points mentioned in the ticket: open-telemetry#29021 (comment) --------- Co-authored-by: Antoine Toulme <antoine@toulme.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
k8s.service.k8s.serviceLink to tracking Issue: #29021
Testing: Added unit tests analogue to the available tests
Documentation: Adjusted readme's of k8s_observer and receivercreator. Added description of new flags and typers.
Note:
Current implementation is working as described in the linked ticket. Please check the potential discussion points mentioned in the ticket: #29021 (comment)