[processor/resourcedetection] Add k8s cluster name detection in EKS environment #28649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ec2 instance tags to determine the EKS k8s cluster name.
github-actions
bot
added
the
processor/resourcedetection
crobert-1
changed the title
dmitryax
reviewed
Oct 26, 2023
processor/resourcedetectionprocessor/internal/aws/eks/detector.go
Outdated
Show resolved
Hide resolved
processor/resourcedetectionprocessor/internal/aws/eks/detector_test.go
Outdated
Show resolved
Hide resolved
processor/resourcedetectionprocessor/internal/aws/eks/detector.go
Outdated
Show resolved
Hide resolved
- Don't panic on error - Remove unrelated changes - Reuse conventions variable for k8s cluster name
|
|
dmitryax
approved these changes
Oct 28, 2023
|
@jinja2 can you please take a look as well? |
dmitryax
reviewed
Oct 31, 2023
jinja2
reviewed
Oct 31, 2023
processor/resourcedetectionprocessor/internal/aws/eks/detector.go
Outdated
Show resolved
Hide resolved
processor/resourcedetectionprocessor/internal/aws/eks/detector.go
Outdated
Show resolved
Hide resolved
processor/resourcedetectionprocessor/internal/aws/eks/detector.go
Outdated
Show resolved
Hide resolved
Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com>
bryan-aguilar
approved these changes
Nov 10, 2023
jinja2
approved these changes
Nov 20, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…nvironment (open-telemetry#28649) **Description:** This enhancement detects the k8s cluster name in EKS. The solution uses EC2 instance tags to determine the cluster name, which means it will only work on EC2 (as noted in documentation updates). Resolves open-telemetry#26794 --------- Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enhancement detects the k8s cluster name in EKS. The solution uses EC2 instance tags to determine the cluster name, which means it will only work on EC2 (as noted in documentation updates).
Note: This is the second attempt at adding this functionality, superseding PR #27408. My first attempt was using
v2of the AWS GO SDK, but theservice/ec2module was causing lint to hit OOM issues and successful lint runs were taking over half an hour to complete. This usesv1of the module instead in an attempt to resolve linting issues.Link to tracking Issue:
Resolves #26794
Testing:
Manual testing in an EKS cluster when running on EC2 instances. Added unit tests to cover basic functionality.
Documentation:
Updated README and relevant metadata