-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdatagen] allow adding resource_attribute warnings #27257
Merged
dmitryax
merged 1 commit into
open-telemetry:main
from
coralogix:main-mdatagen-resource-warnings
Oct 10, 2023
Merged
[mdatagen] allow adding resource_attribute warnings #27257
dmitryax
merged 1 commit into
open-telemetry:main
from
coralogix:main-mdatagen-resource-warnings
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
force-pushed
the
main-mdatagen-resource-warnings
branch
from
September 28, 2023 12:46
7edff94
to
a315d6b
Compare
povilasv
commented
Sep 28, 2023
povilasv
force-pushed
the
main-mdatagen-resource-warnings
branch
from
September 29, 2023 10:47
a315d6b
to
994f2ba
Compare
dmitryax
approved these changes
Sep 29, 2023
povilasv
force-pushed
the
main-mdatagen-resource-warnings
branch
from
October 4, 2023 09:59
994f2ba
to
ea6f2db
Compare
github-actions
bot
added
processor/k8sattributes
k8s Attributes processor
processor/resourcedetection
Resource detection processor
receiver/activedirectoryds
receiver/aerospike
receiver/apache
receiver/apachespark
receiver/azuremonitor
receiver/bigip
receiver/chrony
receiver/couchdb
receiver/dockerstats
receiver/elasticsearch
receiver/expvar
receiver/filestats
receiver/flinkmetrics
receiver/haproxy
receiver/hostmetrics
receiver/httpcheck
HTTP Check receiver
receiver/iis
receiver/k8scluster
receiver/kafkametrics
receiver/kubeletstats
labels
Oct 4, 2023
povilasv
force-pushed
the
main-mdatagen-resource-warnings
branch
4 times, most recently
from
October 5, 2023 11:00
a50e2ef
to
17f1fe1
Compare
👋 FYI this PR changes generated Example of change:
I had to update some receiver tests so that it ignores this internal field |
povilasv
force-pushed
the
main-mdatagen-resource-warnings
branch
3 times, most recently
from
October 5, 2023 12:16
670e248
to
8e368ea
Compare
povilasv
force-pushed
the
main-mdatagen-resource-warnings
branch
from
October 5, 2023 14:38
8e368ea
to
27d0914
Compare
povilasv
requested review from
codeboten,
MovieStoreGuy,
atoulme,
dashpole,
TylerHelmuth,
mx-psi,
Aneurysm9 and
fatsheep9146
as code owners
October 5, 2023 15:17
dmitryax
approved these changes
Oct 10, 2023
Thanks @povilasv! |
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…7257) **Description:** allow adding resource_attribute warnings **Link to tracking Issue:** open-telemetry#19174 **Testing:** - Generated unit tests - Tested manually with some changes to k8sclusterreceiver: ``` k8s.kubelet.version: description: The version of Kubelet running on the node. type: string enabled: false warnings: if_configured: This resource_attribute is deprecated and will be removed soon. opencensus.resourcetype: description: The OpenCensus resource type. type: string enabled: true warnings: if_enabled: This resource_attribute is deprecated and will be removed soon. ``` Gives the following output: ``` {"level":"warn","ts":1695985300.0413303,"caller":"metadata/generated_metrics.go:2201","msg":"[WARNING] `k8s.kubelet.version` should not be configured: This resource_attribute is deprecated and will be removed soon.","kind":"receiver","name":"k8s_cluster","data_type":"metrics"} {"level":"warn","ts":1695985300.041354,"caller":"metadata/generated_metrics.go:2207","msg":"[WARNING] `opencensus.resourcetype` should not be enabled: This resource_attribute is deprecated and will be removed soon.","kind":"receiver","name":"k8s_cluster","data_type":"metrics"} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/mdatagen
mdatagen command
processor/k8sattributes
k8s Attributes processor
processor/resourcedetection
Resource detection processor
receiver/activedirectoryds
receiver/aerospike
receiver/apache
receiver/apachespark
receiver/azuremonitor
receiver/bigip
receiver/chrony
receiver/couchdb
receiver/dockerstats
receiver/elasticsearch
receiver/expvar
receiver/filestats
receiver/flinkmetrics
receiver/haproxy
receiver/hostmetrics
receiver/httpcheck
HTTP Check receiver
receiver/iis
receiver/k8scluster
receiver/kafkametrics
receiver/kubeletstats
receiver/memcached
receiver/mongodb
receiver/mongodbatlas
receiver/mysql
receiver/nginx
receiver/nsxt
NSXT Receiver
receiver/oracledb
receiver/postgresql
receiver/rabbitmq
receiver/redis
Redis related issues
receiver/riak
receiver/saphana
receiver/snowflake
Snowflake receiver
receiver/splunkenterprise
receiver/sqlserver
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
allow adding resource_attribute warnings
Link to tracking Issue: #19174
Testing:
Gives the following output:
Documentation: