Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component: sumologicprocessor #23949

Merged

Conversation

sumo-drosiek
Copy link
Member

@sumo-drosiek sumo-drosiek commented Jul 4, 2023

Description:

Adds Sumo Logic Processor

The Sumo Logic processor (config name: sumologic)
modifies the metadata on logs, metrics and traces sent to Sumo Logic
so that the Sumo Logic apps can make full use of the ingested data.

Link to tracking Issue: #23946

Testing:

  • Unit tests
  • Component is being used by our customers

Documentation: README.md

@sumo-drosiek sumo-drosiek requested review from a team and jpkrohling July 4, 2023 10:17
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jul 4, 2023
@sumo-drosiek
Copy link
Member Author

sumo-drosiek commented Jul 4, 2023

I may try to split that PR to smaller ones if it'll help. Now it is just moved from Sumo Logic repository and adjusted due to Adding nee components instruction

@sumo-drosiek sumo-drosiek changed the title New component: sumologicschemaprocessor New component: sumologicprocessor Jul 4, 2023
@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumologic-schema-processor branch from 29a7a55 to 72356b3 Compare July 4, 2023 11:12
@sumo-drosiek
Copy link
Member Author

sumo-drosiek commented Jul 4, 2023

@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumologic-schema-processor branch from 7ed6d9f to 02205a2 Compare July 4, 2023 13:31
Comment on lines +58 to +86
nest_attributes:
# Defines whether attributes should be nested.
# default = false
enabled: {true, false}

# Defines the string used to separate key names in attributes that are to be nested.
# default = "."
separator: <separator>

# Defines a list of allowed prefixes to be nested.
# For example, if "kubernetes." is in this list, then all "kubernetes.*" attributes will be nested.
# default = []
include: [<prefix>]

# Defines a list of prefixes not allowed to be nested.
# For example, if "k8s." is in this list, then all "k8s.*" attributes will not be nested.
# default = []
exclude: [<prefix>]

# If enabled, then maps that would have only one value will be squashed.
# For example,{"k8s": {"pods": {"a": "A", "b": "B"}}}
# will be squashed to {"k8s.pods": {"a": "A", "b": "B"}}
# default = false
squash_single_values: {true, false}

# Specifies if attributes matching given pattern should be mapped to a common key.
# See "Aggregating attributes" documentation chapter from this document.
# default = []
aggregate_attributes:
- attribute: <attribute>
prefixes: [<prefix>]
- ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: these two features were created as a temporary solution for these issues: #14977 #14946

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the migration path once these are resolved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Mark configuration as deprecated and add warning in case of using it and also instruction how to use new configuration
  2. Remove support for the functionality, but leaving logs in order to avoid confusion with default missing configuration error
  3. Remove logs and configuration option completely

@aboguszewski-sumo
Copy link
Member

I don't know if it's needed, but I confirm my will to be a codeowner for this component.

@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumologic-schema-processor branch 4 times, most recently from 9d4e8f6 to de15738 Compare July 5, 2023 10:25
@atoulme atoulme added the Accepted Component New component has been sponsored label Jul 16, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 30, 2023
@sumo-drosiek
Copy link
Member Author

@evan-bradley Could you take a look?

@github-actions github-actions bot removed the Stale label Aug 1, 2023
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumo-drosiek This PR is fairly large, so I only did a surface pass. I will try to go back and do an in-depth review within a week.

.github/CODEOWNERS Outdated Show resolved Hide resolved
processor/sumologicprocessor/metadata.yaml Outdated Show resolved Hide resolved
processor/sumologicprocessor/README.md Outdated Show resolved Hide resolved
processor/sumologicprocessor/processor.go Outdated Show resolved Hide resolved
processor/sumologicprocessor/processor.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 19, 2023
@sumo-drosiek
Copy link
Member Author

@evan-bradley

@sumo-drosiek This PR is fairly large, so I only did a surface pass

Thank you, I made requested changes

@github-actions github-actions bot removed the Stale label Aug 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 5, 2023
Dominik Rosiek and others added 22 commits October 30, 2023 13:36
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
…gation

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumologic-schema-processor branch from 15de60c to e819f3b Compare October 30, 2023 12:46
Dominik Rosiek added 2 commits October 30, 2023 15:45
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@dmitryax dmitryax merged commit e0c15a4 into open-telemetry:main Oct 30, 2023
82 of 83 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 30, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
**Description:**

Adds Sumo Logic Processor

The Sumo Logic processor (config name: `sumologic`)
modifies the metadata on logs, metrics and traces sent to [Sumo
Logic][sumologic_webpage]
so that the Sumo Logic [apps][sumologic_apps] can make full use of the
ingested data.

[sumologic_webpage]: https://www.sumologic.com
[sumologic_apps]: https://www.sumologic.com/applications/

**Link to tracking Issue:** open-telemetry#23946

**Testing:**

- Unit tests
- Component is being used by our customers

**Documentation:** `README.md`

---------

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
**Description:**

Adds Sumo Logic Processor

The Sumo Logic processor (config name: `sumologic`)
modifies the metadata on logs, metrics and traces sent to [Sumo
Logic][sumologic_webpage]
so that the Sumo Logic [apps][sumologic_apps] can make full use of the
ingested data.

[sumologic_webpage]: https://www.sumologic.com
[sumologic_apps]: https://www.sumologic.com/applications/

**Link to tracking Issue:** open-telemetry#23946

**Testing:**

- Unit tests
- Component is being used by our customers

**Documentation:** `README.md`

---------

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Component New component has been sponsored cmd/otelcontribcol otelcontribcol command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants