Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/logzioexporter] Added scope name to exported logs #20768

Merged
merged 33 commits into from
Jan 8, 2024

Conversation

tamir-michaeli
Copy link
Contributor

Description:
In cases when an instrumentation library is used to export logs, the scope field is not being copied to the exported logs.
With this patch, if the scope field is populated in the original log, the scopeName field in the exported log will contains the name of the scope.
Ex. Adding a feature - Explain what this achieves.-->

Link to tracking Issue: #20659

Testing: Added a test with a scope name.
Changed previous tests to send an empty scope name.

Documentation: Added a note in the readme.

@runforesight
Copy link

runforesight bot commented Apr 9, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 31 minutes 15 seconds compared to main branch avg(31 minutes 19 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (31 minutes 15 seconds less than main branch avg.) and finished at 9th Apr, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute and finished at 9th Apr, 2023.


Job Failed Steps Tests
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
build-dev -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 34 seconds (⚠️ 36 seconds more than main branch avg.) and finished at 9th Apr, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 1 minute 53 seconds and finished at 9th Apr, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 18 seconds (2 minutes 58 seconds less than main branch avg.) and finished at 9th Apr, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  N/A See Details

✅  load-tests workflow has finished in 7 minutes 2 seconds (3 minutes 18 seconds less than main branch avg.) and finished at 9th Apr, 2023.


Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
loadtest (TestIdleMode) -     🔗  N/A See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  N/A See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  N/A See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  N/A See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  N/A See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  N/A See Details
loadtest (TestTraceAttributesProcessor) -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 13 minutes 7 seconds and finished at 9th Apr, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  build-and-test workflow has finished in 35 minutes 37 seconds (10 minutes 58 seconds less than main branch avg.) and finished at 9th Apr, 2023.


Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (connector) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
checks -     🔗  N/A See Details
correctness-metrics -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
correctness-traces -     🔗  N/A See Details
integration-tests -     🔗  N/A See Details
unittest-matrix (1.20, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.20, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.20, processor) -     🔗  N/A See Details
unittest-matrix (1.20, exporter) -     🔗  N/A See Details
unittest-matrix (1.20, extension) -     🔗  N/A See Details
unittest-matrix (1.20, connector) -     🔗  N/A See Details
unittest-matrix (1.20, internal) -     🔗  N/A See Details
unittest-matrix (1.20, other) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, connector) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
rotate-milestone -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@wideberg
Copy link

Hey, just checking to see if there's any progress on this?

@tamir-michaeli
Copy link
Contributor Author

@atoulme Mind taking another look?

@yotamloe
Copy link
Contributor

yotamloe commented Jun 5, 2023

Hey @atoulme :) Are there any more changes needed for this PR to be reviewed?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 20, 2023
@tamir-michaeli
Copy link
Contributor Author

@codeboten Might taking another look?

@github-actions github-actions bot removed the Stale label Oct 23, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 6, 2023
@github-actions github-actions bot removed the Stale label Nov 10, 2023
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 24, 2023
Copy link
Contributor

@yotamloe yotamloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! approved

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @yotamloe, and for your patience @tamir-michaeli.

@MovieStoreGuy you have a request for change, can you take another look

@atoulme
Copy link
Contributor

atoulme commented Jan 8, 2024

@MovieStoreGuy mind merging too?

@MovieStoreGuy MovieStoreGuy merged commit 40f2fb8 into open-telemetry:main Jan 8, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 8, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
…emetry#20768)

**Description:** <Describe what has changed.>
In cases when an instrumentation library is used to export logs, the
scope field is not being copied to the exported logs.
With this patch, if the scope field is populated in the original log,
the scopeName field in the exported log will contains the name of the
scope.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** open-telemetry#20659 

**Testing:** Added a test with a scope name.
Changed previous tests to send an empty scope name.

**Documentation:** Added a note in the readme.

---------

Co-authored-by: Alex Boten <alex@boten.ca>
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Co-authored-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants