Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marking jaeger exporters as deprecated #18503

Merged

Conversation

codeboten
Copy link
Contributor

As per the change in the spec open-telemetry/opentelemetry-specification#2858, support for Jaeger exporters is being deprecated. We should start announcing the deprecation of the jaeger exporters to give users time to migrate.

Signed-off-by: Alex Boten aboten@lightstep.com

As per the change in the spec open-telemetry/opentelemetry-specification#2858, we should start announcing the deprecation of the jaeger exporters to give users time to migrate.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@runforesight
Copy link

runforesight bot commented Feb 10, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(5 seconds) has decreased 40 minutes 44 seconds compared to main branch avg(40 minutes 49 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (40 minutes 44 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 4 minutes (⚠️ 1 minute 1 second more than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details

✅  changelog workflow has finished in 4 minutes 5 seconds and finished at 13th Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  check-links workflow has finished in 4 minutes 53 seconds (⚠️ 2 minutes 20 seconds more than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 11 minutes 40 seconds (6 minutes 23 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
kubernetes-test -     🔗  N/A See Details

✅  load-tests workflow has finished in 32 minutes 48 seconds (⚠️ 16 minutes more than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

 build-and-test workflow has finished in 1 minute 57 seconds (57 minutes 29 seconds less than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
correctness-metrics N/A  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) N/A  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 1479  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2452  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2574  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4684  ❌ 0  ⏭ 0    🔗 See Details

✅  prometheus-compliance-tests workflow has finished in 24 minutes 13 seconds (⚠️ 15 minutes 25 seconds more than main branch avg.) and finished at 13th Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deprecation is a big enough deal to warrant a changelog entry.

exporter/jaegerexporter/README.md Outdated Show resolved Hide resolved
exporter/jaegerthrifthttpexporter/README.md Outdated Show resolved Hide resolved
@codeboten
Copy link
Contributor Author

I think this deprecation is a big enough deal to warrant a changelog entry.

100%, i was waiting on feedback from the community before adding a changelog and getting CI to pass :D

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye jaegerthrifthttpexporter 👋 !

Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten merged commit a45ed93 into open-telemetry:main Feb 13, 2023
@codeboten codeboten deleted the codeboten/deprecate-jaeger-exporters branch February 13, 2023 18:51
jpkrohling pushed a commit that referenced this pull request Sep 9, 2024
**Description:** <Describe what has changed.>
Follow #18503, Marking instanaexporter module as deprecated.

**Link to tracking Issue:** #34994

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Signed-off-by: Murphy Chen <minquan.chen@daocloud.io>
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
**Description:** <Describe what has changed.>
Follow open-telemetry#18503, Marking instanaexporter module as deprecated.

**Link to tracking Issue:** open-telemetry#34994

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Signed-off-by: Murphy Chen <minquan.chen@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants