Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/mysql]: add mysql.uptime metric #14747

Merged
merged 1 commit into from
Jun 1, 2023
Merged

[receiver/mysql]: add mysql.uptime metric #14747

merged 1 commit into from
Jun 1, 2023

Conversation

sumo-drosiek
Copy link
Member

Description:

add mysql.uptime metric

Link to tracking Issue:

#14138

Testing:

unit tests

Documentation:

metadata.yaml

@sumo-drosiek sumo-drosiek requested a review from a team October 6, 2022 09:52
@sumo-drosiek sumo-drosiek changed the title feat(mysqlreceiver): add mysql.uptime metric [receiver/mysql]: add mysql.uptime metric Oct 7, 2022
djaglowski
djaglowski reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a likely addition to the semantic conventions that would define uptime metrics. I think we should wait until that discussion is settled.

@sumo-drosiek sumo-drosiek mentioned this pull request Oct 19, 2022
Closed
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 26, 2022
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 10, 2022
@makeavish
Copy link

This PR is closed already: open-telemetry/opentelemetry-specification#2824
Can we reopen this PR and merge?
@sumo-drosiek

@sumo-drosiek
Copy link
Member Author

This PR is closed already: open-telemetry/opentelemetry-specification#2824 Can we reopen this PR and merge? @sumo-drosiek

It is closed, but is it resolved?

@djaglowski djaglowski reopened this May 31, 2023
@djaglowski
Copy link
Member

In my opinion, at this point we should not wait any longer on adding this metric. Let's make a best effort for now. If necessary, we'll migrate to a new standard prior to declaring the component stable.

The design here looks good to me, just need to rebase.

@github-actions github-actions bot removed the Stale label Jun 1, 2023
feat(mysqlreceiver): add mysql.uptime metric
0a30760 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@djaglowski djaglowski merged commit 76c3082 into open-telemetry:main Jun 1, 2023
@github-actions github-actions bot added this to the next release milestone Jun 1, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
@sumo-drosiek @Caleb-Hurshman
[receiver/mysql]: add mysql.uptime metric (open-telemetry#14747)
50244c4 
feat(mysqlreceiver): add mysql.uptime metric

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
receiver/mysql
Projects
None yet
Milestone
v0.79.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sumo-drosiek @makeavish @djaglowski @bogdandrutu