Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] Add optional metric process.memory.utilization #14633

Conversation

andrzej-stencel
Copy link
Member

Description:

This pull request adds a new optional metric named process.memory.utilization to the metrics scraped by the process scraper of the hostmetrics receiver.

Adding this metric to the semantic conventions has been proposed here:

There's a related system metric system.memory.utilization available in the memory scraper.

Link to tracking Issue:

@andrzej-stencel andrzej-stencel requested a review from a team October 3, 2022 10:42
@andrzej-stencel andrzej-stencel changed the title [receiver/hostmetrics] add process.memory.utilization metric [receiver/hostmetrics] Add process.memory.utilization metric Oct 3, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 18, 2022
@dmitryax
Copy link
Member

please rebase

@dmitryax dmitryax removed the Stale label Oct 18, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-memory-utilization-metric branch 2 times, most recently from baf5dd7 to 8a95244 Compare October 24, 2022 10:07
@andrzej-stencel andrzej-stencel force-pushed the add-process-memory-utilization-metric branch from 8a95244 to 1f16fea Compare November 7, 2022 12:34
@andrzej-stencel
Copy link
Member Author

@dmitryax please take a look at this freshly rebased change

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 23, 2022
@mx-psi mx-psi removed the Stale label Nov 23, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-memory-utilization-metric branch from 1f16fea to 7eec39c Compare November 30, 2022 09:04
@andrzej-stencel andrzej-stencel changed the title [receiver/hostmetrics] Add process.memory.utilization metric [receiver/hostmetrics] Add optional metric process.memory.utilization Nov 30, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-memory-utilization-metric branch from 7eec39c to 7c68c02 Compare December 13, 2022 14:15
@runforesight
Copy link

runforesight bot commented Dec 13, 2022

Foresight Summary

    
Major Impacts

TestConsumeLogsUnexpectedExporterType ❌ failed 2 times in 4 runs (50% fail rate).
TestConsumeTracesUnexpectedExporterType ❌ failed 2 times in 4 runs (50% fail rate).
TestLoadInvalidConfig_NoScrapers ❌ failed 2 times in 3 runs (66% fail rate).
build-and-test-windows duration(4 seconds) has decreased 39 minutes 47 seconds compared to main branch avg(39 minutes 51 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (39 minutes 56 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 31 seconds (2 minutes 10 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 32 seconds (4 minutes 54 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  check-links workflow has finished in 2 minutes 39 seconds (42 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 30 seconds (5 minutes 58 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 12 minutes 24 seconds (4 minutes 3 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

❌  build-and-test workflow has finished in 41 minutes 57 seconds (19 minutes 11 seconds less than main branch avg.) and finished at 13th Dec, 2022. 1 job failed. There are 6 test failures.


Job Failed Steps Tests
unittest-matrix (1.18, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2534  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2534  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 53  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
checks -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) Test deb package     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@andrzej-stencel
Copy link
Member Author

@dmitryax any chance this optional metric can be added? (the build package (deb) job failure doesn't seem related to my changes).

Comment on lines +134 to +135
description: Percentage of total physical memory that is used by the process.
unit: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astencel-sumo it's unclear from the docs and unit if the metric is emitted in a fraction of 1 of percentage. I believe it's the same issue for other "utilization" metrics in hostreceiver. Maybe even not well defined in the spec. Can you please help with making it consistent and clear?

@dmitryax dmitryax merged commit 989a66b into open-telemetry:main Dec 14, 2022
@andrzej-stencel andrzej-stencel deleted the add-process-memory-utilization-metric branch December 15, 2022 07:22
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants