[receiver/hostmetrics] Add process.paging.faults metric
#14604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
force-pushed
the
add-process-paging-faults-metric
branch
2 times, most recently
from
6c61386
to
5fe8cce
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
reviewed
Oct 18, 2022
receiver/hostmetricsreceiver/internal/scraper/processscraper/documentation.md
Outdated
Show resolved
Hide resolved
|
Please rebase |
Account for the fact that the metric is only available on Linux.
andrzej-stencel
force-pushed
the
add-process-paging-faults-metric
branch
from
5fe8cce
to
7374f00
Compare
|
@astencel-sumo PTAL at the failing tests |
andrzej-stencel
force-pushed
the
add-process-paging-faults-metric
branch
from
5e655ed
to
4fc3931
Compare
dmitryax
approved these changes
Oct 20, 2022
dmitryax
added
the
ready to merge
codeboten
approved these changes
Oct 21, 2022
6 tasks
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…etry#14604) This pull request adds a new metric named process.paging.faults to the metrics scraped by the process scraper of the hostmetrics receiver.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds a new metric named
process.paging.faultsto the metrics scraped by theprocessscraper of thehostmetricsreceiver.Adding this metric to the semantic conventions has been proposed here:
There's a related system metric system.paging.faults available in the
pagingscraper.Link to tracking Issue: