[receiver/hostmetrics] Add `process.uptime` metric #14460

andrzej-stencel · 2022-09-23T13:37:06Z

Description:

Adds a new optional metric called process.uptime to the process scraper of the hostmetrics receiver.

Link to tracking Issue:

Here's the original issue about system.uptime that resulted in this pull request: #14130

I'm going to create a PR adding system.uptime as a next step.

Here's the PR to add the metric names to semantic conventions: open-telemetry/opentelemetry-specification#2824.

There's also a related issue proposing a "process create time" metric #14084, which resulted in a proposal to add a process.create_time resource attribute: open-telemetry/opentelemetry-specification#2825.

github-actions · 2022-10-19T05:44:58Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

dmitryax · 2022-10-19T21:46:10Z

@astencel-sumo PTAL at the failing CI

runforesight · 2022-12-15T08:03:15Z

Foresight Summary

Major Impacts

TestConsumeLogsUnexpectedExporterType ❌ failed 2 times in 2 runs (100% fail rate).

TestConsumeTracesUnexpectedExporterType ❌ failed 2 times in 2 runs (100% fail rate).

build-and-test-windows duration(3 seconds) has decreased 40 minutes 52 seconds compared to main branch avg(40 minutes 55 seconds).

View More Details

⭕ build-and-test-windows workflow has finished in 3 seconds (40 minutes 43 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

Job	Failed Steps	Tests
windows-unittest-matrix	- 🔗	N/A	See Details
windows-unittest	- 🔗	N/A	See Details

✅ tracegen workflow has finished in 1 minute 16 seconds (2 minutes 23 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

Job	Failed Steps	Tests
publish-latest	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
build-dev	- 🔗	N/A	See Details

✅ check-links workflow has finished in 1 minute 25 seconds (1 minute 52 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ changelog workflow has finished in 2 minutes 9 seconds (5 minutes 17 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

Job	Failed Steps	Tests
changelog	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 3 minutes 22 seconds (6 minutes 10 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

❌ build-and-test workflow has finished in 28 minutes 49 seconds (31 minutes 25 seconds less than `main` branch avg.) and finished at 15th Dec, 2022. 1 job failed. There are 4 test failures.

Job	Failed Steps	Tests
unittest-matrix (1.18, internal)	- 🔗	✅ 592 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, processor)	- 🔗	✅ 1441 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, internal)	- 🔗	✅ 592 ❌ 0 ⏭ 0 🔗	See Details
correctness-metrics	- 🔗	✅ 2 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	- 🔗	✅ 17 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, processor)	- 🔗	✅ 1441 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-0)	- 🔗	✅ 2537 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	- 🔗	✅ 2537 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	- 🔗	✅ 2237 ❌ 2 ⏭ 0 🔗	See Details
unittest-matrix (1.18, other)	- 🔗	✅ 4363 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-1)	- 🔗	✅ 1854 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, exporter)	- 🔗	✅ 2237 ❌ 2 ⏭ 0 🔗	See Details
unittest-matrix (1.19, other)	- 🔗	✅ 4363 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	- 🔗	✅ 1854 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	- 🔗	✅ 53 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
check-collector-module-version	- 🔗	N/A	See Details
checks	- 🔗	N/A	See Details
check-codeowners	- 🔗	N/A	See Details
lint-matrix (receiver-0)	- 🔗	N/A	See Details
lint-matrix (receiver-1)	- 🔗	N/A	See Details
lint-matrix (processor)	- 🔗	N/A	See Details
lint-matrix (exporter)	- 🔗	N/A	See Details
lint-matrix (extension)	- 🔗	N/A	See Details
lint-matrix (internal)	- 🔗	N/A	See Details
lint-matrix (other)	- 🔗	N/A	See Details
build-examples	- 🔗	N/A	See Details
lint	- 🔗	N/A	See Details
unittest (1.19)	- 🔗	N/A	See Details
unittest (1.18)	- 🔗	N/A	See Details
cross-compile (darwin, amd64)	- 🔗	N/A	See Details
cross-compile (darwin, arm64)	- 🔗	N/A	See Details
cross-compile (linux, 386)	- 🔗	N/A	See Details
cross-compile (linux, amd64)	- 🔗	N/A	See Details
cross-compile (linux, arm)	- 🔗	N/A	See Details
cross-compile (linux, arm64)	- 🔗	N/A	See Details
cross-compile (linux, ppc64le)	- 🔗	N/A	See Details
cross-compile (windows, 386)	Build Collector 🔗	N/A	See Details
cross-compile (windows, amd64)	- 🔗	N/A	See Details
windows-msi	- 🔗	N/A	See Details
build-package	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ load-tests workflow has finished in 26 minutes 59 seconds (⚠️ 10 minutes 4 seconds more than `main` branch avg.) and finished at 15th Dec, 2022.

Job	Failed Steps	Tests
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 19 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

andrzej-stencel · 2022-12-15T13:25:55Z

The build-and-test / cross-compile (windows, 386) job failure seems to be caused by this change in otel core: open-telemetry/opentelemetry-collector#6722

atoulme · 2023-01-22T00:25:19Z

receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper.go

+		return err
+	}
+	processUptime := now.AsTime().UnixMilli() - createTime
+	s.mb.RecordProcessUptimeDataPoint(now, processUptime)


it looks like this will be in milliseconds, when your description of the metric says the value is in seconds.

wbarnha · 2023-05-15T18:47:03Z

Any update on this? It'd be nice to have this feature included.

andrzej-stencel · 2023-05-23T23:38:55Z

Any update on this? It'd be nice to have this feature included.

I'm intending to get back to it, when I tick off some other items on my priority list 🤞

github-actions · 2023-06-07T05:18:44Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

wbarnha · 2023-06-07T05:22:41Z

Commenting to keep this from getting closed.

dmitryax · 2023-06-07T06:02:26Z

@wbarnha feel free to take over this PR if you're interested

wbarnha · 2023-06-07T12:00:58Z

Sounds good, I'll give it a shot

github-actions · 2023-06-22T05:19:23Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

wbarnha · 2023-06-22T05:20:35Z

I'll give it a shot soon, just backlogged with my own projects at the moment.

github-actions · 2023-07-07T05:19:52Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions · 2023-07-22T05:18:42Z

Closed as inactive. Feel free to reopen if this PR is still being worked on.

krantishetty · 2024-02-05T06:59:41Z

Added metrics under process to get the process uptime but it failed with below error
Metric has invalid keys process.uotime
Error decoding receiver's

atoulme · 2024-02-05T16:53:07Z

Please don’t comment on closed issues. You have a typo in your metric key.

krantishetty · 2024-02-09T13:17:53Z

Created no issue, unfortunately I'm not getting any response,
#31107 (comment)
My ask is
process:
metrics:
process.uptime:
enabled: true

error details

'metrics' has invalid keys: process.uptime. collector server run finished with error: failed to get config: cannot unmarshal the confiuration: 1 error(s) decoding:

andrzej-stencel requested a review from a team September 23, 2022 13:37

andrzej-stencel requested a review from dmitryax as a code owner September 23, 2022 13:37

github-actions bot assigned dmitryax Sep 23, 2022

andrzej-stencel changed the title ~~[receiver/hostmetrics]: Add process.uptime metric~~ [receiver/hostmetrics] Add process.uptime metric Sep 29, 2022

andrzej-stencel force-pushed the add-process-uptime-metric branch 2 times, most recently from efda6a3 to 946e505 Compare October 3, 2022 10:51

github-actions bot added the Stale label Oct 19, 2022

andrzej-stencel force-pushed the add-process-uptime-metric branch from 946e505 to 3e71630 Compare October 19, 2022 12:06

dmitryax removed the Stale label Oct 19, 2022

andrzej-stencel force-pushed the add-process-uptime-metric branch 2 times, most recently from 9ed0688 to 3685283 Compare October 24, 2022 10:14

andrzej-stencel force-pushed the add-process-uptime-metric branch 2 times, most recently from 46bc326 to 55ebea8 Compare November 7, 2022 13:41

[receiver/hostmetrics]: Add process.uptime metric

c81b427

andrzej-stencel force-pushed the add-process-uptime-metric branch from 55ebea8 to c81b427 Compare December 15, 2022 08:02

github-actions bot added the receiver/hostmetrics label Dec 15, 2022

atoulme reviewed Jan 22, 2023

View reviewed changes

github-actions bot added the Stale label Jun 7, 2023

dmitryax removed the Stale label Jun 7, 2023

github-actions bot added the Stale label Jun 22, 2023

github-actions bot removed the Stale label Jun 23, 2023

github-actions bot added the Stale label Jul 7, 2023

github-actions bot closed this Jul 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[receiver/hostmetrics] Add `process.uptime` metric #14460

[receiver/hostmetrics] Add `process.uptime` metric #14460

andrzej-stencel commented Sep 23, 2022

github-actions bot commented Oct 19, 2022

dmitryax commented Oct 19, 2022

runforesight bot commented Dec 15, 2022 •

edited

Loading

`TestConsumeLogsUnexpectedExporterType` ❌ failed 2 times in 2 runs (100% fail rate).

`TestConsumeTracesUnexpectedExporterType` ❌ failed 2 times in 2 runs (100% fail rate).

`build-and-test-windows` duration(3 seconds) has decreased 40 minutes 52 seconds compared to main branch avg(40 minutes 55 seconds).

⭕ build-and-test-windows workflow has finished in 3 seconds (40 minutes 43 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 16 seconds (2 minutes 23 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

✅ check-links workflow has finished in 1 minute 25 seconds (1 minute 52 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

✅ changelog workflow has finished in 2 minutes 9 seconds (5 minutes 17 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 22 seconds (6 minutes 10 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

❌ build-and-test workflow has finished in 28 minutes 49 seconds (31 minutes 25 seconds less than `main` branch avg.) and finished at 15th Dec, 2022. 1 job failed. There are 4 test failures.

✅ load-tests workflow has finished in 26 minutes 59 seconds (⚠️ 10 minutes 4 seconds more than `main` branch avg.) and finished at 15th Dec, 2022.

andrzej-stencel commented Dec 15, 2022 •

edited

Loading

atoulme Jan 22, 2023

wbarnha commented May 15, 2023

andrzej-stencel commented May 23, 2023

github-actions bot commented Jun 7, 2023

wbarnha commented Jun 7, 2023

dmitryax commented Jun 7, 2023

wbarnha commented Jun 7, 2023

github-actions bot commented Jun 22, 2023

wbarnha commented Jun 22, 2023

github-actions bot commented Jul 7, 2023

github-actions bot commented Jul 22, 2023

krantishetty commented Feb 5, 2024

atoulme commented Feb 5, 2024

krantishetty commented Feb 9, 2024

[receiver/hostmetrics] Add process.uptime metric #14460

[receiver/hostmetrics] Add process.uptime metric #14460

Conversation

andrzej-stencel commented Sep 23, 2022

github-actions bot commented Oct 19, 2022

dmitryax commented Oct 19, 2022

runforesight bot commented Dec 15, 2022 • edited Loading

Foresight Summary

TestConsumeLogsUnexpectedExporterType ❌ failed 2 times in 2 runs (100% fail rate).

TestConsumeTracesUnexpectedExporterType ❌ failed 2 times in 2 runs (100% fail rate).

build-and-test-windows duration(3 seconds) has decreased 40 minutes 52 seconds compared to main branch avg(40 minutes 55 seconds).

⭕ build-and-test-windows workflow has finished in 3 seconds (40 minutes 43 seconds less than main branch avg.) and finished at 15th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 16 seconds (2 minutes 23 seconds less than main branch avg.) and finished at 15th Dec, 2022.

✅ check-links workflow has finished in 1 minute 25 seconds (1 minute 52 seconds less than main branch avg.) and finished at 15th Dec, 2022.

✅ changelog workflow has finished in 2 minutes 9 seconds (5 minutes 17 seconds less than main branch avg.) and finished at 15th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 22 seconds (6 minutes 10 seconds less than main branch avg.) and finished at 15th Dec, 2022.

❌ build-and-test workflow has finished in 28 minutes 49 seconds (31 minutes 25 seconds less than main branch avg.) and finished at 15th Dec, 2022. 1 job failed. There are 4 test failures.

✅ load-tests workflow has finished in 26 minutes 59 seconds (⚠️ 10 minutes 4 seconds more than main branch avg.) and finished at 15th Dec, 2022.

andrzej-stencel commented Dec 15, 2022 • edited Loading

atoulme Jan 22, 2023

Choose a reason for hiding this comment

wbarnha commented May 15, 2023

andrzej-stencel commented May 23, 2023

github-actions bot commented Jun 7, 2023

wbarnha commented Jun 7, 2023

dmitryax commented Jun 7, 2023

wbarnha commented Jun 7, 2023

github-actions bot commented Jun 22, 2023

wbarnha commented Jun 22, 2023

github-actions bot commented Jul 7, 2023

github-actions bot commented Jul 22, 2023

krantishetty commented Feb 5, 2024

atoulme commented Feb 5, 2024

krantishetty commented Feb 9, 2024

[receiver/hostmetrics] Add `process.uptime` metric #14460

[receiver/hostmetrics] Add `process.uptime` metric #14460

runforesight bot commented Dec 15, 2022 •

edited

Loading

`TestConsumeLogsUnexpectedExporterType` ❌ failed 2 times in 2 runs (100% fail rate).

`TestConsumeTracesUnexpectedExporterType` ❌ failed 2 times in 2 runs (100% fail rate).

`build-and-test-windows` duration(3 seconds) has decreased 40 minutes 52 seconds compared to main branch avg(40 minutes 55 seconds).

⭕ build-and-test-windows workflow has finished in 3 seconds (40 minutes 43 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 16 seconds (2 minutes 23 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

✅ check-links workflow has finished in 1 minute 25 seconds (1 minute 52 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

✅ changelog workflow has finished in 2 minutes 9 seconds (5 minutes 17 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 22 seconds (6 minutes 10 seconds less than `main` branch avg.) and finished at 15th Dec, 2022.

❌ build-and-test workflow has finished in 28 minutes 49 seconds (31 minutes 25 seconds less than `main` branch avg.) and finished at 15th Dec, 2022. 1 job failed. There are 4 test failures.

✅ load-tests workflow has finished in 26 minutes 59 seconds (⚠️ 10 minutes 4 seconds more than `main` branch avg.) and finished at 15th Dec, 2022.

andrzej-stencel commented Dec 15, 2022 •

edited

Loading