honeycomb: adjust the sample rate using an attribute on the span #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 89.80% 89.82% +0.02%
==========================================
Files 274 274
Lines 13475 13486 +11
==========================================
+ Hits 12101 12114 +13
+ Misses 1009 1008 -1
+ Partials 365 364 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@chris-smith-zocdoc please fix the linter issues |
dmitryax
approved these changes
Oct 7, 2020
|
To link the original spec issue: open-telemetry/opentelemetry-specification#570. Many thanks for this! |
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
Don't bother to add a report unless there has been a coverage change. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allows setting Honeycomb's sample rate using an attribute on span.
This allows either a custom processor (my use case) or the application sdks to adjust the sample rate value for honeycomb. Once the sampling otel is finalized this implementation could be adjusted to use that instead of a custom attribute.
Testing:
Added unit test
Documentation:
Updated exporter readme