Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Add Base64Decode Converter #31543

Closed
DougManton opened this issue Mar 4, 2024 · 3 comments
Closed

[pkg/ottl] Add Base64Decode Converter #31543

DougManton opened this issue Mar 4, 2024 · 3 comments
Labels
enhancement New feature or request pkg/ottl priority:p2 Medium

Comments

@DougManton
Copy link
Contributor

Component(s)

pkg/ottl

Is your feature request related to a problem? Please describe.

OTTL has no way to convert a base64 encoded string to plaintext, preventing the import of logs where the vendor encodes strings

Describe the solution you'd like

Add a new Converter, Base64Decode, that accepts a base64 encoded string and returns the decoded string.

Describe alternatives you've considered

Intermediary software to process inbound logs and decode base64 strings before passing to opentelemetry collector

Additional context

I am currently running a local fork with my implementation of a base64 decode function, I will create a branch and link it here.

@DougManton DougManton added enhancement New feature or request needs triage New item requiring triage labels Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

DougManton added a commit to DougManton/opentelemetry-collector-contrib that referenced this issue Mar 4, 2024
**Description:** Adds a new `Base64Decode` function to facilitate ingest of base64 encoded data

**Link to tracking Issue:** open-telemetry#31543

**Testing:**  Added unit test

**Documentation:**  Updated the func readme.
@TylerHelmuth TylerHelmuth added priority:p2 Medium and removed needs triage New item requiring triage labels Mar 12, 2024
@TylerHelmuth
Copy link
Member

Seems reasonable to me, and so would the inverse. We typically stick with specific functions, so I am ok with a specific Base64Decode instead of a generic Decode.

DougManton added a commit to DougManton/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
**Description:** Adds a new `Base64Decode` function to facilitate ingest of base64 encoded data

**Link to tracking Issue:** open-telemetry#31543

**Testing:**  Added unit test

**Documentation:**  Updated the func readme.
DougManton added a commit to DougManton/opentelemetry-collector-contrib that referenced this issue Mar 14, 2024
evan-bradley pushed a commit that referenced this issue Mar 14, 2024
**Description:** Adds a new Base64Decode function to facilitate ingest
of base64 encoded data

**Link to tracking Issue:**
#31543

**Testing:** Added unit and e2e tests

**Documentation:** Updated the func readme.
@evan-bradley
Copy link
Contributor

Closing as resolved via #31730. If you'd like to also add an encoding function, please feel free to reopen this issue or create another issue to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg/ottl priority:p2 Medium
Projects
None yet
Development

No branches or pull requests

3 participants