Add event name field, fix leading dot in FQN of attribute w/o prefix. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
enhancement
Oberon00
commented
Sep 15, 2021
| @@ -117,7 +117,10 @@ def parse( | |||
| if attr_id is not None: | |||
| validate_id(attr_id, position_data["id"]) | |||
| attr_type, brief, examples = SemanticAttribute.parse_id(attribute) | |||
| fqn = "{}.{}".format(prefix, attr_id) | |||
| if prefix: | |||
There was a problem hiding this comment.
I did not add this bugfix to the changelog because IMHO the prefix being optional is a misfeature, and we should require the prefix and/or default it to the semantic convention ID.
mariojonke
approved these changes
Sep 16, 2021
bogdandrutu
approved these changes
Oct 1, 2021
arminru
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All event semantic conventions now have a
name: strattribute. This defaults to theprefix, but if no prefix is given or a different name is desired, can be manually set with thenameproperty in the YAML.The markdown generator adds a single line before the table for event semantic conventions, see semantic-conventions/src/tests/data/markdown/event/expected.md
Events with dynamic names are not supported, as there is currently no use case in the spec.
CC @bogdandrutu
This needs a spec follow-up, I created open-telemetry/opentelemetry-specification#1922