Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify warning & fix line number #109

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Clarify warning & fix line number #109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
982b435
clarify warning, fix line number
CleanCut Jul 25, 2022
59082e3
max line length lint
CleanCut Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions semantic-conventions/src/opentelemetry/semconv/model/semantic_convention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ def parse_semantic_convention_groups(yaml_file):
def SemanticConvention(group):
type_value = group.get("type")
if type_value is None:
line = group.lc.data["id"][1] + 1
line = group.lc.data["id"][0] + 1
print(
"Using default SPAN type for semantic convention '{}' @ line {}".format(
"Please set the type for group '{}' on line {} - defaulting to type 'span'. See https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/syntax.md#groups".format(
CleanCut marked this conversation as resolved.
Show resolved Hide resolved
group["id"], line
),
file=sys.stderr,
Expand Down