Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add sisig pizza recipe #72

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

nickaldwin
Copy link
Contributor

@nickaldwin nickaldwin commented Feb 1, 2024

Description

This PR adds a section about Sisig Pizza to the pizza-recipe.md file.

What type of PR is this? (check all applicable)

  • ☝️ Add a pizza fact or trivia
  • 🧑‍🍳 Add a pizza recipe
  • 🗺️ Add a regional pizza
  • 📝 Documentation Update

Related Tickets & Documents

Relates to #32

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

[optional] What GIF best describes this PR or how it makes you feel?

😊

@CBID2 CBID2 self-requested a review February 1, 2024 23:18
@CBID2
Copy link
Contributor

CBID2 commented Feb 1, 2024

Hi @nickaldwin! :) Can you fill out the other sections of your Pull Request's form please? It'll make it easier for me to review your contribution. Consider using this Pull Request as an example.

@nickaldwin
Copy link
Contributor Author

Hi @CBID2 i update the PR form i apologize if i skip the comments thank you

@CBID2
Copy link
Contributor

CBID2 commented Feb 2, 2024

Hi @CBID2 i update the PR form i apologize if i skip the comments thank you

@nickaldwin, you haven't linked the issue that your PR addresses. It's done like this:
Relates to #issue number
This is the issue your pull request addresses

@nickaldwin
Copy link
Contributor Author

nickaldwin commented Feb 2, 2024

Hi @CBID2 i update the PR form i apologize if i skip the comments thank you

@nickaldwin, you haven't linked the issue that your PR addresses. It's done like this: Relates to #issue number This is the issue your pull request addresses

oh i missed that one
You're close @nickaldwin! 😁
Add Relates to next to the issue number. Keywords are important when linking issues in PRs. They automatically close the issue once a PR is merged.

i see it thanks 😁

@nickaldwin
Copy link
Contributor Author

Hi @CBID2, I hope this is correct this time. I have updated the pull request description with related tickets and documents. This closes #72

@CBID2
Copy link
Contributor

CBID2 commented Feb 2, 2024

Hi @CBID2, I hope this is correct this time. I have updated the pull request description with related tickets and documents. This closes #72

@nickaldwin, the description is good but the Related Tickets section is still incorrect.

@CBID2
Copy link
Contributor

CBID2 commented Feb 2, 2024

@nickaldwin read the last paragraph in this issue: #36
It's the one that corresponds to your PR.

@nickaldwin
Copy link
Contributor Author

hi @CBID2 i figured it out i update the related and tickets & docs section

@CBID2
Copy link
Contributor

CBID2 commented Feb 2, 2024

hi @CBID2 i figured it out i update the related and tickets & docs section

Alright, now we're getting somewhere @nickaldwin! :) Now, I can officially review your contribution

@nickaldwin
Copy link
Contributor Author

@CBID2 thank you

Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @nickaldwin! :) As you continue your open source journey, remember to fill out every section of your pull request’s form. It makes it easier for maintainers and other contributors to review your contribution. If you enjoyed your experience with us, share your rating on Repo-Rater, and join our Discord for more updates on OpenSauced & to find other projects.

@CBID2 CBID2 merged commit b08da20 into open-sauced:main Feb 2, 2024
@nickaldwin
Copy link
Contributor Author

@CBID2 I should pay attention to details in things thank you so much for your advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants