Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added Nick Taylor's blog posts #327

Merged
merged 8 commits into from
Jun 10, 2024
Merged

chore: added Nick Taylor's blog posts #327

merged 8 commits into from
Jun 10, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Jun 10, 2024 •
edited
Loading

Description

Imports Nick Taylor's (@nickytonline) OpenSauced blog posts from dev.to

Related Tickets & Documents

Relates to #328

Mobile & Desktop Screenshots/Recordings

CleanShot 2024-06-10 at 10 50 58

Steps to QA

  1. Go to https://deploy-preview-327--saucedocs.netlify.app/community-resources/ and scroll down the list. You should start seeing posts by Nick, e.g. https://deploy-preview-327--saucedocs.netlify.app/community-resources/creating-an-og-image-using-react-and-netlify-edge-functions/

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@netlify Netlify
Copy link

netlify bot commented Jun 10, 2024 •
edited
Loading

✅ Deploy Preview for saucedocs ready!

Name Link
🔨 Latest commit 6a908ec
🔍 Latest deploy log https://app.netlify.com/sites/saucedocs/deploys/66676c029e646100082d1ee4
😎 Deploy Preview https://deploy-preview-327--saucedocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline
Copy link
Member Author

nickytonline commented Jun 10, 2024 •
edited
Loading

Need to sort out some errors: fixed

Compiled with problems:
×
ERROR in ./blog/2024/2024-01-23-the-native-browser-dialog-element-1nhn.md?truncated=true
Module build failed (from ./node_modules/@docusaurus/mdx-loader/lib/index.js):
Error: MDX compilation failed for file "/Users/nicktaylor/dev/work/docs/blog/2024/2024-01-23-the-native-browser-dialog-element-1nhn.md"
Cause: Expected a closing tag for `<dialog>` (80:17-80:25) before the end of `link`
Details:
{
  "column": 16,
  "message": "Expected a closing tag for `<dialog>` (80:17-80:25) before the end of `link`",
  "line": 80,
  "name": "80:16-80:93",
  "place": {
    "start": {
      "line": 80,
      "column": 16,
      "offset": 4688,
      "_index": 0,
      "_bufferIndex": 13
    },
    "end": {
      "line": 80,
      "column": 93,
      "offset": 4765,
      "_index": 0,
      "_bufferIndex": 90
    }
  },
  "reason": "Expected a closing tag for `<dialog>` (80:17-80:25) before the end of `link`",
  "ruleId": "end-tag-mismatch",
  "source": "mdast-util-mdx-jsx"
}

    at Object.mdxLoader (/Users/nicktaylor/dev/work/docs/node_modules/@docusaurus/mdx-loader/lib/loader.js:130:25)
ERROR in ./blog/2024/2024-01-23-the-native-browser-dialog-element-1nhn.md
Module build failed (from ./node_modules/@docusaurus/mdx-loader/lib/index.js):
Error: MDX compilation failed for file "/Users/nicktaylor/dev/work/docs/blog/2024/2024-01-23-the-native-browser-dialog-element-1nhn.md"
Cause: Expected a closing tag for `<dialog>` (80:17-80:25) before the end of `link`
Details:
{
  "column": 16,
  "message": "Expected a closing tag for `<dialog>` (80:17-80:25) before the end of `link`",
  "line": 80,
  "name": "80:16-80:93",
  "place": {
    "start": {
      "line": 80,
      "column": 16,
      "offset": 4688,
      "_index": 0,
      "_bufferIndex": 13
    },
    "end": {
      "line": 80,
      "column": 93,
      "offset": 4765,
      "_index": 0,
      "_bufferIndex": 90
    }
  },
  "reason": "Expected a closing tag for `<dialog>` (80:17-80:25) before the end of `link`",
  "ruleId": "end-tag-mismatch",
  "source": "mdast-util-mdx-jsx"
}

    at Object.mdxLoader (/Users/nicktaylor/dev/work/docs/node_modules/@docusaurus/mdx-loader/lib/loader.js:130:25)
ERROR in ./blog/2024/2024-04-16-creating-an-og-image-using-react-and-netlify-edge-functions-563a.md?truncated=true
Module build failed (from ./node_modules/@docusaurus/mdx-loader/lib/index.js):
Error: MDX compilation failed for file "/Users/nicktaylor/dev/work/docs/blog/2024/2024-04-16-creating-an-og-image-using-react-and-netlify-edge-functions-563a.md"
Cause: Expected a closing tag for `<head>` (33:57-33:63) before the end of `image`
Details:
{
  "column": 1,
  "message": "Expected a closing tag for `<head>` (33:57-33:63) before the end of `image`",
  "line": 33,
  "name": "33:1-33:192",
  "place": {
    "start": {
      "line": 33,
      "column": 1,
      "offset": 2287,
      "_index": 0,
      "_bufferIndex": 0
    },
    "end": {
      "line": 33,
      "column": 192,
      "offset": 2478,
      "_index": 1,
      "_bufferIndex": -1
    }
  },
  "reason": "Expected a closing tag for `<head>` (33:57-33:63) before the end of `image`",
  "ruleId": "end-tag-mismatch",
  "source": "mdast-util-mdx-jsx"
}

    at Object.mdxLoader (/Users/nicktaylor/dev/work/docs/node_modules/@docusaurus/mdx-loader/lib/loader.js:130:25)
ERROR in ./blog/2024/2024-04-16-creating-an-og-image-using-react-and-netlify-edge-functions-563a.md
Module build failed (from ./node_modules/@docusaurus/mdx-loader/lib/index.js):
Error: MDX compilation failed for file "/Users/nicktaylor/dev/work/docs/blog/2024/2024-04-16-creating-an-og-image-using-react-and-netlify-edge-functions-563a.md"
Cause: Expected a closing tag for `<head>` (33:57-33:63) before the end of `image`
Details:
{
  "column": 1,
  "message": "Expected a closing tag for `<head>` (33:57-33:63) before the end of `image`",
  "line": 33,
  "name": "33:1-33:192",
  "place": {
    "start": {
      "line": 33,
      "column": 1,
      "offset": 2287,
      "_index": 0,
      "_bufferIndex": 0
    },
    "end": {
      "line": 33,
      "column": 192,
      "offset": 2478,
      "_index": 1,
      "_bufferIndex": -1
    }
  },
  "reason": "Expected a closing tag for `<head>` (33:57-33:63) before the end of `image`",
  "ruleId": "end-tag-mismatch",
  "source": "mdast-util-mdx-jsx"
}

    at Object.mdxLoader (/Users/nicktaylor/dev/work/docs/node_modules/@docusaurus/mdx-loader/lib/loader.js:130:25)

@nickytonline nickytonline marked this pull request as ready for review June 10, 2024 14:38
@nickytonline nickytonline requested a review from a team as a code owner June 10, 2024 14:38
@nickytonline nickytonline self-assigned this Jun 10, 2024
@nickytonline
Copy link
Member Author

nickytonline commented Jun 10, 2024 •
edited
Loading

Just looking into broken links causing the build to fail. fixed

https://app.netlify.com/sites/saucedocs/deploys/66670f763604db00083af316#L97-L122

@nickytonline nickytonline force-pushed the nickytonline/nick-taylor-blog-posts branch from 7cd68cd to 1cda663 Compare June 10, 2024 15:11
@BekahHW
Copy link
Member

BekahHW commented Jun 10, 2024

writing gif

adiati98
adiati98 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes gif

@nickytonline nickytonline merged commit 5724d52 into main Jun 10, 2024
11 checks passed
@nickytonline nickytonline deleted the nickytonline/nick-taylor-blog-posts branch June 10, 2024 21:15
@nickytonline
Copy link
Member Author

@BekahHW and @adiati98, just FYI that I've updated the Canonical URLs on DEV to point to the opensauced.pizza links.

@jpmcb jpmcb mentioned this pull request Jun 21, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BekahHW BekahHW BekahHW approved these changes

@adiati98 adiati98 adiati98 approved these changes

Assignees

@nickytonline nickytonline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickytonline @BekahHW @adiati98