Build to all OpenSSL versions #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstebila
reviewed
Oct 17, 2022
| openssl_version=$($OPENSSL_APP version) | ||
|
|
||
| if [[ "$openssl_version" = "OpenSSL 3.0."* ]]; then | ||
| echo "Skipping CMS test for OpenSSL 3.0" |
There was a problem hiding this comment.
I'm a bit rusty on bash but is this actually how you do string matching in bash? Won't the * try to do file name globbing?
There was a problem hiding this comment.
Won't the * try to do file name globbing?
AFAIK not when using double brackets. Besides, it worked :-) Here's an independent opinion from StackOverflow: https://stackoverflow.com/questions/229551/how-to-check-if-a-string-contains-a-substring-in-bash . After having read that, though, I noticed the single "=" -- now fixed.
dstebila
approved these changes
Oct 17, 2022
baentsch
force-pushed
the
mb-alwaysbuild
branch
from
eec133b
to
7d9b8db
Compare
baentsch
force-pushed
the
mb-alwaysbuild
branch
from
7d9b8db
to
38d6e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
Also documents upstream limitations by version.