Address stateful-sigs comments in #1650 #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baentsch
reviewed
Jan 9, 2024
baentsch
reviewed
Jan 9, 2024
baentsch
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Also thanks for these updates/improvements, @ducnguyen-sb ! Please see single comments.
ducnguyen-sb
commented
Jan 9, 2024
ashman-p
approved these changes
Jan 11, 2024
baentsch
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Looks like an improvement to the current "surprise exit" approach, so good for me. Same caveats as stated in another place, though: Do we want to expose this new API externally? Testing of the new API considered done implicitly by its use in the SHA implementations.
|
@baentsch Ah, I think these APIs should be used internally. |
SWilson4
pushed a commit
that referenced
this pull request
Feb 14, 2024
cothan
pushed a commit
that referenced
this pull request
Apr 2, 2024
SWilson4
pushed a commit
that referenced
this pull request
Apr 12, 2024
SWilson4
pushed a commit
that referenced
this pull request
Apr 12, 2024
SWilson4
pushed a commit
that referenced
this pull request
Apr 12, 2024
SWilson4
pushed a commit
that referenced
this pull request
May 14, 2024
cothan
pushed a commit
that referenced
this pull request
May 14, 2024
SWilson4
pushed a commit
that referenced
this pull request
May 14, 2024
* Address stateful-sigs comments in #1650 (#1656) * Add sig_stfl to configure.md * Add OQS_MEM_checked_malloc and OQS_MEM_checked_aligned_alloc * Use memcpy and checked_malloc * Zeroing internal state memory on heap Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu> * make astyle happy Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu> * secure free for wots key,sig tree stack Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu> * revert * fix markdown link invalid Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu> * fix markdown link, work with doxygen 1.10 Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu> --------- Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu> Co-authored-by: Duc Nguyen <106774416+ducnguyen-sb@users.noreply.github.com>
cothan
added a commit
that referenced
this pull request
May 30, 2024
commit 244288f Add XMSS parameter xmss_sha256_h10 (#1482) commit a7e26d9 Add 12 XMSS and 16 XMSSMT parameters. (#1489) commit 4694fc3 Add secret key object to XMSS (#1530) commit 99067be Add XMSS Serialize/Deserialize (#1542) commit 2dbfc40 Update XMSS secret key object APIs, sync with LMS (#1588) commit 47740ad Enforce idx from unsigned int to uint32_t. (#1611) commit 9610576 Fix windows-x86 and arm compiling error. (#1634) commit bb658b7 Address stateful-sigs comments in #1650 (#1656) commit 7db8ddf Update `sig_stfl.h` document for #1650 (#1655) commit c3e5750 Add Apache 2.0 and MIT License to XMSS (#1662) commit e1f02b2 Change XMSS License from `(Apache 2.0 AND MIT)` to `(Apache 2.0 OR MIT) AND CC0-1.0` (#1697) commit 17c12c3 Add return status for XMSS lock/unlock functions. (#1712) commit 1941636 Add return check for lock/unlock function (#1727) commit b45415c Use `abort()` instead of exit to get the trace log. (#1728) commit ba63672 Reduce number of `malloc/free` call in `XMSS/external` (#1724) Signed-off-by: Duc Tri Nguyen <dnguye69@gmu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
checked_mallocandchecked_aligned_allocAs mentioned in #1650 , liboqs has a existing pattern
exit(111)when the malloc allocation failed. This PR addOQS_MEM_checked_mallocandOQS_MEM_checked_aligned_alloc.Two APIs will abruptly exit the program, but at least let user know what happens.
For now, it's close to impossible to propagate errors to callers without a lot of rewrite in the library.
Use
memcpyinstead of for loopThere is a pattern in
sha2_armv8.candsha2_c.cthat use the for loop to perform an array copy.Changed to
memcpy. This change enables compiler optimizations.Add Stateful signature flags to
CONFIGURE.mdFixed minor grammar errors, and add stateful signature flags description.