Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LMS updated to use new SK API #1533

Merged
merged 8 commits into from
Aug 29, 2023
Merged

LMS updated to use new SK API #1533

merged 8 commits into from
Aug 29, 2023

Conversation

ashman-p
Copy link
Contributor

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@ashman-p
Copy link
Contributor Author

Looks like variant XMSS-SHAKE_20_256 is hanging. This should be addressed after things settle with all the API changes.

SWilson4
SWilson4 reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions from me, but overall everything looks good.

src/sig_stfl/lms/sig_stfl_lms_functions.c Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms_functions.c Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms_functions.c Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms_functions.c Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms_functions.c Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms_functions.c Outdated Show resolved Hide resolved
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms_functions.c Outdated Show resolved Hide resolved
src/sig_stfl/lms/sig_stfl_lms_functions.c Outdated Show resolved Hide resolved
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
@ashman-p ashman-p marked this pull request as draft August 28, 2023 17:34
@ashman-p ashman-p marked this pull request as ready for review August 28, 2023 20:55
@ashman-p
Copy link
Contributor Author

Will look at the macOS build in a subsequent commit since the issue seems not related to the current commit.

1 similar comment
@ashman-p
Copy link
Contributor Author

Will look at the macOS build in a subsequent commit since the issue seems not related to the current commit.

@ashman-p ashman-p merged commit ec3d3e0 into stateful-sigs Aug 29, 2023
22 checks passed
@ducnguyen-sb ducnguyen-sb mentioned this pull request Sep 7, 2023
Merged
2 tasks
@ashman-p ashman-p deleted the na-stfl-sig-lms-1 branch October 4, 2023 04:30
SWilson4 pushed a commit that referenced this pull request Dec 15, 2023
@ashman-p @SWilson4
LMS updated to use new SK API (#1533)
ab2eb39 
* Use secret key struct in LMS. Update de/serialize sk API

* Updates per comments

* Update per comments

* Fix mem leak

* Address scan bild issue

* Removed unused variable

* Remove unused struc member

* Address macOS-noopenssl build failures
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
@ashman-p @SWilson4
LMS updated to use new SK API (#1533)
9fffce3 
* Use secret key struct in LMS. Update de/serialize sk API

* Updates per comments

* Update per comments

* Fix mem leak

* Address scan bild issue

* Removed unused variable

* Remove unused struc member

* Address macOS-noopenssl build failures
cothan pushed a commit that referenced this pull request Apr 2, 2024
@ashman-p @cothan
LMS updated to use new SK API (#1533)
d9a272e 
* Use secret key struct in LMS. Update de/serialize sk API

* Updates per comments

* Update per comments

* Fix mem leak

* Address scan bild issue

* Removed unused variable

* Remove unused struc member

* Address macOS-noopenssl build failures
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ashman-p @SWilson4
LMS updated to use new SK API (#1533)
234f13d 
* Use secret key struct in LMS. Update de/serialize sk API

* Updates per comments

* Update per comments

* Fix mem leak

* Address scan bild issue

* Removed unused variable

* Remove unused struc member

* Address macOS-noopenssl build failures
SWilson4 pushed a commit that referenced this pull request May 14, 2024
@ashman-p @SWilson4
LMS updated to use new SK API (#1533)
245aede 
* Use secret key struct in LMS. Update de/serialize sk API

* Updates per comments

* Update per comments

* Fix mem leak

* Address scan bild issue

* Removed unused variable

* Remove unused struc member

* Address macOS-noopenssl build failures
ashman-p added a commit that referenced this pull request Jun 4, 2024
@ashman-p
I, Norman Ashley, retroactively sign off on these commits:
3621a6b 
commit e356ebf Na lms (#1486)
commit 55094c3 LMS H5_W1 (#1513)
commit 4d773d7 Convert to use OQS_SIG_STFL_SECRET_KEY struct  (#1525)
commit 245aede LMS updated to use new SK API (#1533)
commit a85a9aa Stateful sigs secret key storage callback (#1553)
commit 3934949 Na statful sig lock (#1559)
commit 3db6b44 Secret Key Query  (#1572)
commit 2446c64 Na stateful sigs lms var (#1574)
commit 8df2539 Stateful sigs XMSS updates (#1590)
commit a7b2987 SHA2 Increment with arbitrary length (non-block sizes) (#1614)
commit 2dd9e07 Na lms kat multi level (#1620)
commit 982b440 Fix Build Errors (#1635)
commit ddae644 Various fixes
commit cc50ef0 Fix warning
commit cf03392 Update README.md
commit 9325713 Update README.md
commit a52b217 Update README.md
commit d442ac9 Update README.md
commit 72ab478 Update README.md
commit 5967f12 Update src/CMakeLists.txt
commit fc6d512 Update documentation and license text. (#1663)
commit e7a83c7 Disable Stateful Signatures in the build by default (#1676)
commit 6c81bae Na stateful macro (#1687)

Signed-off-by: Norman Ashley <nashley@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWilson4 SWilson4 SWilson4 approved these changes

@dstebila dstebila Awaiting requested review from dstebila

@ducnguyen-sb ducnguyen-sb Awaiting requested review from ducnguyen-sb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashman-p @SWilson4 @ducnguyen-sb