-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy from upstream (Kyber), add pqcrystals-* licenses to README #1403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the term "...or..." between the licenses correct/sensible? I'm not a lawyer, but those guys could understand "or" to mean "the stricter of the two". What's your (lawyer's) take, @beldmit as you raised the issue in #1388? Does this resolve the "CC0" problem for Fedora? Is it OK we still only have CC0 for ARM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this change presumably gives OQS more legal freedom & wider acceptance, good for me too. Will merge early next week if no objections heard by @beldmit.
Thank you very much! It's a significant step forward! |
Re-reviewing things I wonder whether there's now a mismatch between upstream repo and |
Oh I missed to update the algorithm documentation yml/md for both Dilithium and Kyber, will add it with a commit. Thanks for noticing. |
Fixes #1402