Add schema_url attribute to Resource #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
…elemetry-python-contrib into add-schema_url-attribute
eddyleelin
reviewed
May 25, 2021
CHANGELOG.md
Outdated
| @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - Fixed cases where description was used with non-error status code when creating Status objects. | |||
| ([#504](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/504)) | |||
| ### Changed | |||
| - Added optional `schema_url` field to `Resource` class | |||
| ([opentelemetry-python #1862](https://github.com/open-telemetry/opentelemetry-python/issues/1862)) | |||
There was a problem hiding this comment.
Copied from my comment in the core PR
By the way, this should be the number and link to the PR you submit on the upstream repo. Since you usually wouldn't have submitted it yet, you could just put TBD here until you submit to upstream. Or, you could also use the one you accidentally opened/closed and re-open that PR 😄
eddyleelin
reviewed
May 25, 2021
exporter/opentelemetry-exporter-datadog/tests/test_datadog_exporter.py
Outdated
Show resolved
Hide resolved
alolita
approved these changes
May 25, 2021
Co-authored-by: Eddy Lin <elindy26@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in the OTel specification requires a new
schema_urlfield in theResourceclass. This change modifies tests which used the old constructor signature.Type of change
How Has This Been Tested?
All
toxtests were ran on Python 3.9. One test was modified to account for the change in constructor signature.Does This PR Require a Contrib Repo Change?
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/Yes. - Link to PR: Add schema_url attribute to Resource opentelemetry-python#23 NOTE: The GitHub workflow tests for this PR depend on the linked PR.
No.
Checklist: