-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix knn multi-gpu bug #634
Conversation
Codecov ReportBase: 81.61% // Head: 82.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #634 +/- ##
===========================================
+ Coverage 81.61% 82.11% +0.50%
===========================================
Files 135 135
Lines 4961 4921 -40
Branches 672 660 -12
===========================================
- Hits 4049 4041 -8
+ Misses 774 743 -31
+ Partials 138 137 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Multi-gpu results and single gpu results
![image](https://user-images.githubusercontent.com/36138628/207843327-791389c1-a56e-45f0-8312-1b360d428b7f.png)
![image](https://user-images.githubusercontent.com/36138628/207843356-c3cb5eb1-7569-4532-8424-fe4cfbbfc070.png)
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: