Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init_cfg in resnet backbone #697

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

puhsu
Copy link
Contributor

@puhsu puhsu commented Jul 12, 2021

Here is the quick fix for resnet backbone init_cfg option I talked about in #695

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #697 (c4b458e) into master (f5be6e2) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c4b458e differs from pull request most recent head ed0123e. Consider uploading reports for the commit ed0123e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   85.18%   85.18%           
=======================================
  Files         105      105           
  Lines        5670     5670           
  Branches      923      923           
=======================================
  Hits         4830     4830           
  Misses        662      662           
  Partials      178      178           
Flag Coverage Δ
unittests 85.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/resnet.py 99.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5be6e2...ed0123e. Read the comment docs.

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@xvjiarui xvjiarui merged commit e610ed1 into open-mmlab:master Jul 15, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants