Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support ISPRS Potsdam Dataset. #1097

Merged
merged 26 commits into from
Jan 18, 2022

Conversation

Junjue-Wang
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Enhance the dataset diversity for MMSegmentation in Remote Sensing.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@MengzhangLI
Copy link
Contributor

Hi, @Junjue-Wang Thanks for your nice work.

We would review this pr ASAP.

Best,

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1097 (c161c14) into master (6c3e63e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   90.10%   90.13%   +0.02%     
==========================================
  Files         126      127       +1     
  Lines        7430     7447      +17     
  Branches     1239     1240       +1     
==========================================
+ Hits         6695     6712      +17     
  Misses        530      530              
  Partials      205      205              
Flag Coverage Δ
unittests 90.13% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/core/evaluation/class_names.py 90.90% <100.00%> (+2.02%) ⬆️
mmseg/datasets/__init__.py 100.00% <100.00%> (ø)
mmseg/datasets/potsdam.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3e63e...c161c14. Read the comment docs.

@Junjun2016
Copy link
Collaborator

Hi @Junjue-Wang
Thanks for your contribution again.
Please fix the lint error and refine the PR message.

@MengzhangLI MengzhangLI added the WIP Work in process label Dec 2, 2021
@MengzhangLI MengzhangLI self-assigned this Dec 2, 2021
@Junjue-Wang
Copy link
Contributor Author

@MengzhangLI I have already added the vaihingen api

@MengzhangLI
Copy link
Contributor

Copy that. I would review & test your code in the next few days.

Thank you.

mmseg/datasets/isprs.py Outdated Show resolved Hide resolved
configs/pspnet/pspnet.yml Outdated Show resolved Hide resolved
configs/pspnet/pspnet.yml Outdated Show resolved Hide resolved
configs/pspnet/pspnet.yml Outdated Show resolved Hide resolved
configs/pspnet/pspnet.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeowZheng MeowZheng merged commit b997a13 into open-mmlab:master Jan 18, 2022
@MengzhangLI MengzhangLI removed WIP Work in process Merging PR waited for merging labels Jan 18, 2022
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* add isprs potsdam dataset

* add isprs dataset configs

* fix lint error

* fix potsdam conversion bug

* fix error in potsdam class

* fix error in potsdam class

* add vaihingen dataset

* add vaihingen dataset

* add vaihingen dataset

* fix some description errors.

* fix some description errors.

* fix some description errors.

* upload models & logs of Potsdam

* remove vaihingen and add unit test

* add chinese readme

* add pseudodataset

* use mmcv and add class_names

* use f-string

* add new dataset unittest

* add docstring and remove global variables args

* fix metafile error in PSPNet

* fix pretrained value

* Add dataset info

* fix typo

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants