-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support RMosaic #344
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #344 +/- ##
==========================================
- Coverage 30.86% 30.74% -0.13%
==========================================
Files 119 119
Lines 7934 7989 +55
Branches 1220 1227 +7
==========================================
+ Hits 2449 2456 +7
- Misses 5384 5432 +48
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thank you for your PR! It's cool! |
Ok, I'll update it later. |
Please follow https://github.com/open-mmlab/mmcv/blob/master/CONTRIBUTING.md to set pre-commit hook and fix the lint error. |
Thanks! I'm confused about that. |
Thanks for your explaining @liuyanyi . I'll have a try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
does mosaic transform should combine with mixup? if that ,could you give a sample? |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
1.Support RMosaic
(PS: Corresponding codes in mmdetection shows Mosaic must be used with
RandomAffine
. But I findResize
is also working. )BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
Use the train_pipeline as belowing:
Visualization
Checklist