Add GroupFisher pruning algorithm. #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2023 14:26
wilxy
reviewed
Feb 16, 2023
tests/test_impl/test_pruning/test_group_fisher/test_algorithm.py
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| @MODELS.register_module() | ||
| def GroupFisherDeploySubModel(architecture, |
There was a problem hiding this comment.
I suggest adding examples of the use of GroupFisherDeploySubModel and GroupFisherSubModel in README.
Currently, users can only learn how to use them through test cases (TestPruneDeploySubModel and TestPruneSubModel), which is not user-friendly.
There was a problem hiding this comment.
I will solve this problem when writing documents.
added 14 commits
February 16, 2023 14:22
pppppM
approved these changes
Feb 17, 2023
wilxy
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add GroupFisher pruning algorithm.