Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FGD #110

Open
wants to merge 2 commits into
base: dev_v0.3.0
Choose a base branch
from
Open

add FGD #110

wants to merge 2 commits into from

Conversation

yzd-v
Copy link

@yzd-v yzd-v commented Mar 11, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add FGD(CVPR2022) for MMRazor

Modification

Add fgd config and fgd loss.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@pppppM pppppM requested a review from HIT-cwh March 11, 2022 12:13
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #110 (105489c) into dev_v0.3.0 (81e0e34) will increase coverage by 2.67%.
The diff coverage is 15.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_v0.3.0     #110      +/-   ##
==============================================
+ Coverage       58.46%   61.14%   +2.67%     
==============================================
  Files              87       91       +4     
  Lines            3154     3361     +207     
  Branches          581      602      +21     
==============================================
+ Hits             1844     2055     +211     
+ Misses           1223     1201      -22     
- Partials           87      105      +18     
Flag Coverage Δ
unittests 61.14% <15.00%> (+2.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrazor/models/losses/fgd.py 13.55% <13.55%> (ø)
mmrazor/models/losses/__init__.py 100.00% <100.00%> (ø)
mmrazor/models/pruners/utils/switchable_bn.py 30.76% <0.00%> (-69.24%) ⬇️
mmrazor/models/pruners/ratio_pruning.py 64.51% <0.00%> (-35.49%) ⬇️
mmrazor/utils/setup_env.py 72.72% <0.00%> (-27.28%) ⬇️
mmrazor/models/algorithms/autoslim.py 56.58% <0.00%> (-14.73%) ⬇️
mmrazor/utils/misc.py 95.23% <0.00%> (-4.77%) ⬇️
mmrazor/models/pruners/structure_pruning.py 85.75% <0.00%> (-2.64%) ⬇️
mmrazor/apis/mmseg/inference.py 65.21% <0.00%> (ø)
mmrazor/apis/mmcls/inference.py 55.17% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e0e34...105489c. Read the comment docs.

humu789 pushed a commit to humu789/mmrazor that referenced this pull request Feb 13, 2023
…#110)

* Add remaining tests

* Use another method to import

* try to fix ppl import error

* try to fix pyppl import bug 2

* try to fix pyppl import error 3

* try to fix pyppl import error 4

* Use test class

* remove ()

* lint

* add else branch
@OpenMMLab-Assistant003
Copy link

Hi @yzd-v!We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @yzd-v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants