Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested predict #1716

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Nested predict #1716

merged 3 commits into from
Jul 28, 2023

Conversation

marouaneamz
Copy link
Contributor

@marouaneamz marouaneamz commented Jul 19, 2023

#1554 merged with the new version of dev

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 35.05% and project coverage change: -2.92% ⚠️

Comparison is base (f9dcae2) 68.16% compared to head (6840330) 65.24%.
Report is 54 commits behind head on dev.

❗ Current head 6840330 differs from pull request most recent head 132aa33. Consider uploading reports for the commit 132aa33 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1716      +/-   ##
==========================================
- Coverage   68.16%   65.24%   -2.92%     
==========================================
  Files         295      332      +37     
  Lines       23372    25843    +2471     
  Branches     3713     4130     +417     
==========================================
+ Hits        15932    16862     +930     
- Misses       6880     8362    +1482     
- Partials      560      619      +59     
Flag Coverage Δ
unittests 65.24% <35.05%> (-2.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mmpretrain/apis/feature_extractor.py 37.50% <0.00%> (ø)
mmpretrain/apis/image_caption.py 30.64% <0.00%> (ø)
mmpretrain/apis/image_retrieval.py 21.42% <0.00%> (ø)
mmpretrain/apis/visual_grounding.py 27.53% <0.00%> (ø)
mmpretrain/apis/visual_question_answering.py 25.67% <0.00%> (ø)
mmpretrain/datasets/__init__.py 60.46% <0.00%> (-13.83%) ⬇️
mmpretrain/datasets/flickr30k_caption.py 0.00% <0.00%> (ø)
mmpretrain/datasets/flickr30k_retrieval.py 0.00% <0.00%> (ø)
mmpretrain/datasets/gqa_dataset.py 0.00% <0.00%> (ø)
mmpretrain/datasets/nocaps.py 0.00% <0.00%> (ø)
... and 67 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit e7fc25c into open-mmlab:dev Jul 28, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants