Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve]Enable binary operators on the NPU. #1714

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

LRJKD
Copy link

@LRJKD LRJKD commented Jul 18, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Enable binary operators on the NPU.

Modification

The mmcls/utils/distribution.py file is modified.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (748ab7a) 22.62% compared to head (7f45193) 22.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           mmcls-0.x    #1714   +/-   ##
==========================================
  Coverage      22.62%   22.63%           
==========================================
  Files            142      142           
  Lines           9927     9929    +2     
  Branches        1621     1621           
==========================================
+ Hits            2246     2247    +1     
- Misses          7675     7676    +1     
  Partials           6        6           
Flag Coverage Δ
unittests 22.63% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/utils/distribution.py 7.89% <33.33%> (+2.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ginray
Copy link
Contributor

Ginray commented Jul 18, 2023

/lgtm

@mzr1996 mzr1996 merged commit 4ec2509 into open-mmlab:mmcls-0.x Jul 19, 2023
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants