Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support NoCap dataset based on BLIP. #1582

Merged
merged 5 commits into from
May 23, 2023

Conversation

wangbo-zhao
Copy link
Contributor

Support NoCap dataset based on BLIP.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@wangbo-zhao wangbo-zhao changed the title [Feature] c [Feature] Support NoCap dataset based on BLIP. May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 13.91% and project coverage change: -1.05 ⚠️

Comparison is base (f9dcae2) 68.16% compared to head (89c1dfe) 67.12%.

❗ Current head 89c1dfe differs from pull request most recent head 234659b. Consider uploading reports for the commit 234659b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1582      +/-   ##
==========================================
- Coverage   68.16%   67.12%   -1.05%     
==========================================
  Files         295      303       +8     
  Lines       23372    23854     +482     
  Branches     3713     3777      +64     
==========================================
+ Hits        15932    16012      +80     
- Misses       6880     7279     +399     
- Partials      560      563       +3     
Flag Coverage Δ
unittests 67.12% <13.91%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpretrain/datasets/__init__.py 70.27% <0.00%> (-4.02%) ⬇️
mmpretrain/datasets/gqa_dataset.py 0.00% <0.00%> (ø)
mmpretrain/datasets/nocaps.py 0.00% <0.00%> (ø)
mmpretrain/datasets/scienceqa.py 0.00% <ø> (ø)
mmpretrain/models/multimodal/__init__.py 40.00% <0.00%> (-4.45%) ⬇️
...retrain/models/multimodal/chinese_clip/__init__.py 0.00% <0.00%> (ø)
mmpretrain/models/multimodal/chinese_clip/bert.py 0.00% <0.00%> (ø)
...ain/models/multimodal/chinese_clip/chinese_clip.py 0.00% <0.00%> (ø)
mmpretrain/models/multimodal/chinese_clip/utils.py 0.00% <0.00%> (ø)
mmpretrain/models/utils/__init__.py 83.33% <0.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wangbo-zhao
Copy link
Contributor Author

I run this and it achieves expected performance.

@mzr1996 mzr1996 merged commit a779c8c into open-mmlab:dev May 23, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants