Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add ScienceQA Metrics #1577

Merged
merged 6 commits into from
May 22, 2023

Conversation

YuanLiuuuuuu
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@YuanLiuuuuuu YuanLiuuuuuu requested a review from mzr1996 May 19, 2023 10:37
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -16.21 ⚠️

Comparison is base (c9a0cb0) 84.37% compared to head (f9dcae2) 68.16%.

❗ Current head f9dcae2 differs from pull request most recent head 74f2465. Consider uploading reports for the commit 74f2465 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1577       +/-   ##
===========================================
- Coverage   84.37%   68.16%   -16.21%     
===========================================
  Files         142      295      +153     
  Lines        9925    23372    +13447     
  Branches     1621     3713     +2092     
===========================================
+ Hits         8374    15932     +7558     
- Misses       1277     6880     +5603     
- Partials      274      560      +286     
Flag Coverage Δ
unittests 68.16% <ø> (-16.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 437 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mzr1996 mzr1996 changed the base branch from multimodal to dev May 22, 2023 01:45
@mzr1996 mzr1996 changed the base branch from dev to multimodal May 22, 2023 01:46
mmpretrain/evaluation/metrics/scienceqa.py Outdated Show resolved Hide resolved
mmpretrain/evaluation/metrics/scienceqa.py Outdated Show resolved Hide resolved
mmpretrain/evaluation/metrics/scienceqa.py Outdated Show resolved Hide resolved
@mzr1996 mzr1996 changed the base branch from multimodal to dev May 22, 2023 03:33
@YuanLiuuuuuu YuanLiuuuuuu merged commit d04ef8a into open-mmlab:dev May 22, 2023
5 of 6 checks passed
@YuanLiuuuuuu YuanLiuuuuuu deleted the scienceqa_metrics branch May 22, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants