Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Chinese CLIP #1576

Merged
merged 13 commits into from
May 22, 2023
Merged

[Feature] Support Chinese CLIP #1576

merged 13 commits into from
May 22, 2023

Conversation

fangyixiao18
Copy link
Collaborator

@fangyixiao18 fangyixiao18 commented May 19, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Results of R50
image

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -17.27 ⚠️

Comparison is base (c9a0cb0) 84.37% compared to head (cf99fe0) 67.10%.

❗ Current head cf99fe0 differs from pull request most recent head 677e146. Consider uploading reports for the commit 677e146 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1576       +/-   ##
===========================================
- Coverage   84.37%   67.10%   -17.27%     
===========================================
  Files         142      299      +157     
  Lines        9925    23762    +13837     
  Branches     1621     3769     +2148     
===========================================
+ Hits         8374    15945     +7571     
- Misses       1277     7255     +5978     
- Partials      274      562      +288     
Flag Coverage Δ
unittests 67.10% <ø> (-17.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 441 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fangyixiao18 fangyixiao18 requested a review from mzr1996 May 22, 2023 02:01
@mzr1996 mzr1996 merged commit 1e47846 into open-mmlab:dev May 22, 2023
6 of 7 checks passed
zzc98 pushed a commit to zzc98/mmclassification that referenced this pull request May 22, 2023
* support cn-clip

* update README

* Update progress bar

* update order of category

* fix lint

* update

* update readme and metafile

* update

* update docstring

* refactor tokenizer

* fix lint

* Update README and progress bar

---------

Co-authored-by: mzr1996 <mzr1996@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants