Incorrect stage freeze on RIFormer Model #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default value of frozen stage is set to 0, and the doc says that this will lead to no stage be frozen. But the actual case is the patch_embed will be freezed. This may cause incorrect training, thus influencing the result. I suggest a careful review.
|
Please note that the "if" condition of freeze operation on self.patch_embed itself was not modified (line 364), but all code modification is actually trying to fix its logical mistake. |
zzc98
pushed a commit
to zzc98/mmclassification
that referenced
this pull request
May 22, 2023
* [Doc] RIFormer's README did not link to its paper properly * Incorrect code for reproducing RIFormer the default value of frozen stage is set to 0, and the doc says that this will lead to no stage be frozen. But the actual case is the patch_embed will be freezed. This may cause incorrect training, thus influencing the result. I suggest a careful review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The reproduce code of RIFormer seems to be incorrect when handling stage freeze. This may cause an incorrect result.
Add the correct arxiv website of RIFormer to Readme.
Modification
Repair the index in for loop of freeze_stage. Change the default value of freeze_stage to -1.
Add the paper pdf website to its Readme.
BC-breaking (Optional)
I'm uncertain whether this modification will disrupt the standardization of the 'freeze_stage' parameter in the mmpretrain project.