Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add InternImage Classification project #1569

Merged
merged 20 commits into from
Jun 13, 2023

Conversation

zzc98
Copy link
Contributor

@zzc98 zzc98 commented May 17, 2023

Motivation

Add InternImage Classification project. The source code is from OpenGVLab/InternImage.

Modification

Support InternImage Classification on ImageNet1k dataset.

The result is below,

name resolution acc@1 acc@5
InternImage-T 224 83.4700 96.5340
InternImage-S 224 84.1640 96.9320
InternImage-B 224 84.8660 97.1820
InternImage-L 384 87.7060 98.3820
InternImage-XL 384 88.0460 98.5620
InternImage-H 640 89.5500 98.8500
InternImage-G 512 90.0580 98.9700

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 45.61% and project coverage change: -1.08 ⚠️

Comparison is base (f9dcae2) 68.16% compared to head (d8c5c17) 67.09%.

❗ Current head d8c5c17 differs from pull request most recent head 21ef80c. Consider uploading reports for the commit 21ef80c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1569      +/-   ##
==========================================
- Coverage   68.16%   67.09%   -1.08%     
==========================================
  Files         295      308      +13     
  Lines       23372    24572    +1200     
  Branches     3713     3898     +185     
==========================================
+ Hits        15932    16487     +555     
- Misses       6880     7481     +601     
- Partials      560      604      +44     
Flag Coverage Δ
unittests 67.09% <45.61%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpretrain/apis/image_retrieval.py 21.42% <ø> (ø)
mmpretrain/datasets/__init__.py 68.42% <0.00%> (-5.87%) ⬇️
mmpretrain/datasets/gqa_dataset.py 0.00% <0.00%> (ø)
mmpretrain/datasets/nocaps.py 0.00% <0.00%> (ø)
mmpretrain/datasets/scienceqa.py 0.00% <ø> (ø)
mmpretrain/datasets/textvqa.py 0.00% <0.00%> (ø)
mmpretrain/models/classifiers/image.py 89.83% <0.00%> (-3.16%) ⬇️
mmpretrain/models/multimodal/__init__.py 40.00% <0.00%> (-4.45%) ⬇️
...retrain/models/multimodal/chinese_clip/__init__.py 0.00% <0.00%> (ø)
mmpretrain/models/multimodal/chinese_clip/bert.py 0.00% <0.00%> (ø)
... and 29 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmpretrain/models/classifiers/image.py Outdated Show resolved Hide resolved
projects/internimage_classification/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current configs are too redundant and could be written in the following structure:

configs 
    ├── _base_.py # all data, schedler, runtime setting of interimage
    ├── tiny.py                      
    ├── small.py             
    └── base.py           

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fangyixiao18 fangyixiao18 merged commit 3eaf719 into open-mmlab:dev Jun 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants