Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix multi-task-head loss potential bug #1530

Merged
merged 2 commits into from
May 6, 2023

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Apr 27, 2023

Motivation

in the pull request #1229 , for the extreme case that we have a full-mask we do for the loss = 0 which will cause problems to calculate the gradient of the loss. here i use the torch vector of the image to create a loss =0

#1393

the same as #1426

Modification

Please briefly describe what modification is made in this PR.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.54 🎉

Comparison is base (c9a0cb0) 84.37% compared to head (af478ae) 84.91%.

❗ Current head af478ae differs from pull request most recent head fe72c37. Consider uploading reports for the commit fe72c37 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1530      +/-   ##
==========================================
+ Coverage   84.37%   84.91%   +0.54%     
==========================================
  Files         142      230      +88     
  Lines        9925    17556    +7631     
  Branches     1621     2758    +1137     
==========================================
+ Hits         8374    14908    +6534     
- Misses       1277     2130     +853     
- Partials      274      518     +244     
Flag Coverage Δ
unittests 84.91% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 372 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ezra-Yu Ezra-Yu requested a review from fangyixiao18 May 6, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants