Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the bug in binary cross entropy loss #1499

Merged
merged 3 commits into from
Apr 19, 2023
Merged

[Fix] Fix the bug in binary cross entropy loss #1499

merged 3 commits into from
Apr 19, 2023

Conversation

wangbo-zhao
Copy link
Contributor

@wangbo-zhao wangbo-zhao commented Apr 19, 2023

Motivation

Fix the bug in binary cross entropy loss when using multi-label datasets e.g.VOC2007

The issue from #1495 .

Fix CI according to some experiments, From mim install -e . --> mim install .

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

 Fix the bug in binary cross entropy loss when using multi-label datasets e.g.VOC2007
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.53 🎉

Comparison is base (c9a0cb0) 84.37% compared to head (3a9c48c) 84.90%.

❗ Current head 3a9c48c differs from pull request most recent head b4e1f70. Consider uploading reports for the commit b4e1f70 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1499      +/-   ##
==========================================
+ Coverage   84.37%   84.90%   +0.53%     
==========================================
  Files         142      230      +88     
  Lines        9925    17558    +7633     
  Branches     1621     2758    +1137     
==========================================
+ Hits         8374    14908    +6534     
- Misses       1277     2132     +855     
- Partials      274      518     +244     
Flag Coverage Δ
unittests 84.90% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 372 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ezra-Yu Ezra-Yu merged commit e954cf0 into open-mmlab:dev Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants