Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Refine Inference Doc #1489

Merged
merged 5 commits into from
May 6, 2023
Merged

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Apr 14, 2023

Motivation

as title. not include the ImageRetrievalInferencer

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Collaborator

@fangyixiao18 fangyixiao18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese version?

docs/en/user_guides/inference.md Outdated Show resolved Hide resolved
docs/en/user_guides/inference.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.84 🎉

Comparison is base (c9a0cb0) 84.37% compared to head (9f64af8) 85.21%.

❗ Current head 9f64af8 differs from pull request most recent head e1761bb. Consider uploading reports for the commit e1761bb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1489      +/-   ##
==========================================
+ Coverage   84.37%   85.21%   +0.84%     
==========================================
  Files         142      239      +97     
  Lines        9925    17949    +8024     
  Branches     1621     2802    +1181     
==========================================
+ Hits         8374    15296    +6922     
- Misses       1277     2133     +856     
- Partials      274      520     +246     
Flag Coverage Δ
unittests 85.21% <ø> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 381 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

>>> imgs = ['https://github.com/open-mmlab/mmpretrain/raw/main/demo/demo.JPEG'] * 5
>>> results = inferencer(imgs, batch_size=2)
>>> print(results[1]['pred_class'])
海蛇
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the output of pred_class is Chinese?

@fangyixiao18 fangyixiao18 merged commit 9cf37b3 into open-mmlab:dev May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants