Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in test tools #1309

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Fix bug in test tools #1309

merged 3 commits into from
Jan 12, 2023

Conversation

csatsurnh
Copy link
Contributor

@csatsurnh csatsurnh commented Jan 12, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Originial code assign the result of list.append() to a variable which is None and cause error.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@csatsurnh csatsurnh changed the base branch from master to 1.x January 12, 2023 05:14
@CLAassistant
Copy link

CLAassistant commented Jan 12, 2023

CLA assistant check
All committers have signed the CLA.

@csatsurnh csatsurnh changed the base branch from 1.x to dev-1.x January 12, 2023 05:15
@csatsurnh csatsurnh changed the title Fix list append Fix bug in test tools Jan 12, 2023
@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Jan 12, 2023

Please sign the CLA so that we can review this PR.

@csatsurnh
Copy link
Contributor Author

Please sign the CLA so that we can review this PR.

Done

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit c73a5a8 into open-mmlab:dev-1.x Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants