[Feat] Support specify gpu for testing and training with gpu-id instead of gpu-ids and gpus #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 84.53% 84.62% +0.08%
==========================================
Files 165 165
Lines 10664 10664
Branches 1622 1622
==========================================
+ Hits 9015 9024 +9
+ Misses 1303 1295 -8
+ Partials 346 345 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaotongxiao
reviewed
Jan 26, 2022
gaotongxiao
reviewed
Jan 26, 2022
gaotongxiao
reviewed
Jan 26, 2022
gaotongxiao
approved these changes
Jan 26, 2022
gaotongxiao
added a commit
to gaotongxiao/mmocr
that referenced
this pull request
Jul 15, 2022
…ad of gpu-ids and gpus (open-mmlab#756) * support set gpu number for testing and deprecate gpu_ids and gpus with gpu_id * update gpu-ids gpus and gpu-id dostring * add args.gpus process * fix typo Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
gaotongxiao
added a commit
to gaotongxiao/mmocr
that referenced
this pull request
Jul 15, 2022
…ad of gpu-ids and gpus (open-mmlab#756) * support set gpu number for testing and deprecate gpu_ids and gpus with gpu_id * update gpu-ids gpus and gpu-id dostring * add args.gpus process * fix typo Co-authored-by: Tong Gao <gaotongxiao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-mmlab/mmdetection#7019
Motivation
If the number of GPUs is more than 1, there will be an assertion error in MMDP because MMDP does not support the situation with more than one GPU.
Modification
--gpu-ids is changed to --gpu-id.
BC-breaking (Optional)
--gpus-ids and --gpus will be deprecated, please use --gpu-id.