[Fix] Fix bug in non-distributed multi-gpu training/testing #7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZwwWayne
approved these changes
Jan 19, 2022
ZwwWayne
reviewed
Jan 19, 2022
| type=int, | ||
| help='number of gpus to use ' |
There was a problem hiding this comment.
We should add deprecation warning of --gpu-ids and --gpus to indicate users that they are deprecated and useless. We should not delete them immediately.
1 task
6 tasks
ZwwWayne
approved these changes
Jan 26, 2022
6 tasks
gaotongxiao
reviewed
Jan 26, 2022
6 tasks
chhluo
pushed a commit
to chhluo/mmdetection
that referenced
this pull request
Feb 21, 2022
…ab#7019) * Fix bug in non-distributed training/testing * Add deprecated message
ZwwWayne
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Fix bug in non-distributed training/testing * Add deprecated message
ZwwWayne
pushed a commit
to ZwwWayne/mmdetection
that referenced
this pull request
Jul 19, 2022
…ab#7019) * Fix bug in non-distributed training/testing * Add deprecated message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MMDP does not support non-distributed multi-GPU training, --gpus in train.py lost its role, so it is removed, --gpu-ids is changed to --gpu-id, because only one GPU can be specified for non-distribution training and testing.
If the number of GPUs is more than 1, there will be an assertion error in MMDP because MMDP does not support the situation with more than one GPU.