Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Fix sampler unit test. #6284

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

RangiLyu
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers

Modification

Fix import path incorrect in sampler unit test.
Fix a potential bug in the unit test of the VOC dataset.

BC-breaking (Optional)

None

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #6284 (a8ea29d) into master (c88509c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6284   +/-   ##
=======================================
  Coverage   61.80%   61.80%           
=======================================
  Files         315      315           
  Lines       25157    25163    +6     
  Branches     4185     4185           
=======================================
+ Hits        15549    15553    +4     
  Misses       8798     8798           
- Partials      810      812    +2     
Flag Coverage Δ
unittests 61.78% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/bbox/samplers/random_sampler.py 75.00% <0.00%> (-5.56%) ⬇️
mmdet/datasets/pipelines/transforms.py 76.91% <0.00%> (-0.18%) ⬇️
mmdet/models/detectors/two_stage.py 68.23% <0.00%> (ø)
mmdet/models/roi_heads/standard_roi_head.py 62.11% <0.00%> (ø)
mmdet/models/dense_heads/yolact_head.py 79.55% <0.00%> (+0.17%) ⬆️
mmdet/core/bbox/assigners/max_iou_assigner.py 73.68% <0.00%> (+1.31%) ⬆️
mmdet/models/detectors/yolact.py 97.36% <0.00%> (+3.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88509c...a8ea29d. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 78e3ec8 into open-mmlab:master Oct 15, 2021
@RangiLyu RangiLyu deleted the fix_ci_2 branch January 13, 2022 08:16
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants