Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add optional score threshold option to coco_error_analysis.py #11117

Merged

Conversation

guyleaf
Copy link
Contributor

@guyleaf guyleaf commented Nov 1, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

In some models, e.g., DETR, it does not support filtering score after prediction.
By adding score threshold option, we could filter the detection bboxes in flexible way.

It is also a common case to visualize the actual performance in dataset.
For example, positive bbox with low confident score will affect the AP and AR going higher.

Modification

  • Add optional score threshold to coco_error_analysis.py
  • Filter the detection bboxes with the score threshold when user set it.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hhaAndroid
Copy link
Collaborator

@guyleaf Please fix the lint

@guyleaf guyleaf force-pushed the guyleaf/enchance-coco-error-analysis branch from 2302345 to 8f354f9 Compare November 6, 2023 12:10
@guyleaf
Copy link
Contributor Author

guyleaf commented Nov 6, 2023

@guyleaf Please fix the lint

Done.

@hhaAndroid hhaAndroid merged commit 4a516c3 into open-mmlab:dev-3.x Nov 7, 2023
8 of 10 checks passed
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants