Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case case_sensitive in scandir #1389

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Add case case_sensitive in scandir #1389

merged 4 commits into from
Oct 20, 2021

Conversation

Ezra-Yu
Copy link
Contributor

@Ezra-Yu Ezra-Yu commented Oct 8, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Some file suffixs are case-insensitive, such as ".JPG" and ".jpg", so add case_sensitive option in scandir. Default True, behave as before.
For example, scandir(root, suffix='JPG', case_sensitive=False) can find pictures with suffix of both ".JPG" and ".jpg" , whilescandir(root, suffix='JPG') can only find pictures with suffix of ".JPG" .

Modification

Add case_sensitive option in scandir. Default True, behave as before.
if set case_sensitive to False, ignore the case of suffix.

BC-breaking (Optional)

No.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2021

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida self-requested a review October 8, 2021 17:10
mmcv/utils/path.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida changed the title Add case case_insensitive in scandir Add case case_sensitive in scandir Oct 17, 2021
@ZwwWayne ZwwWayne merged commit e8489a7 into open-mmlab:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants