-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add voxel ops from mmdet3d #1381
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
==========================================
- Coverage 68.59% 68.24% -0.36%
==========================================
Files 164 166 +2
Lines 10891 10995 +104
Branches 1991 1996 +5
==========================================
+ Hits 7471 7503 +32
- Misses 3030 3102 +72
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better add a voxelize test.
Voxelization test failed with:
|
Motivation
Add voxel operation from mmdet3d (branch: v1.0.0.dev0).
Modification
Several files in mmcv/ops folder.
BC-breaking (Optional)
No.
Use cases (Optional)
from mmcv.ops import DynamicScatter, dynamic_scatter, Voxelization, voxelization