Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lmdeploy pytorch engine #875

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Support lmdeploy pytorch engine #875

merged 5 commits into from
Feb 22, 2024

Conversation

RunningLeon
Copy link
Contributor

Motivation

Support eval models with lmdeploy pytorch engine.

Modification

  • add eval config
  • add LmdeployPytorchModel

BC-breaking (Optional)

None

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@RunningLeon RunningLeon changed the title Support pytorch engine [WIP]: Support pytorch engine Feb 6, 2024
@Leymore Leymore marked this pull request as draft February 6, 2024 16:30
@RunningLeon RunningLeon changed the title [WIP]: Support pytorch engine Support pytorch engine Feb 7, 2024
@RunningLeon RunningLeon changed the title Support pytorch engine Support lmdeploy pytorch engine Feb 7, 2024
@RunningLeon RunningLeon marked this pull request as ready for review February 21, 2024 04:14
@RunningLeon
Copy link
Contributor Author

@grimoire @lvhan028 Could you guys review this PR? THX

lvhan028
lvhan028 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leymore Leymore merged commit 32ba0b0 into open-compass:main Feb 22, 2024
9 checks passed
Leymore pushed a commit that referenced this pull request Apr 23, 2024
@RunningLeon @BunnyRunnerX
Support lmdeploy pytorch engine (#875)
864d15c 
* add lmdeploy pytorch model

* fix

* speed up encoding and decoding

* fix

* change tokenizer
liuyaox pushed a commit to liuyaox/opencompass that referenced this pull request Jun 26, 2024
@RunningLeon
Support lmdeploy pytorch engine (open-compass#875)
2165460 
* add lmdeploy pytorch model

* fix

* speed up encoding and decoding

* fix

* change tokenizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@Leymore Leymore Leymore approved these changes

@grimoire grimoire Awaiting requested review from grimoire

Assignees

@Leymore Leymore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RunningLeon @grimoire @lvhan028 @Leymore