Skip to content

Commit

Permalink
TravisCI: Don't run tests with race.
Browse files Browse the repository at this point in the history
This modifies the goclean.sh script that is executed on Travis to
only run the tests without the race detector.

While it is nice to run the race detector on the tests, unfortunately
there is a limit to the number of goroutines that can be launched while
running it.  Since Travis is now much slower than it once was, this
causes a ton of false positive failures.
  • Loading branch information
davecgh committed Jul 1, 2017
1 parent 9f0e66e commit 6487ba1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions goclean.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
# 3. go vet (http://golang.org/cmd/vet)
# 4. gosimple (https://github.com/dominikh/go-simple)
# 5. unconvert (https://github.com/mdempsky/unconvert)
# 6. race detector (http://blog.golang.org/race-detector)
#
# gometalinter (github.com/alecthomas/gometalinter) is used to run each static
# checker.
Expand Down Expand Up @@ -36,4 +35,4 @@ test -z "$(gometalinter -j 4 --disable-all \
--enable=gosimple \
--enable=unconvert \
--deadline=10m $linter_targets 2>&1 | grep -v 'ALL_CAPS\|OP_' 2>&1 | tee /dev/stderr)"
env GORACE="halt_on_error=1" go test -race -tags rpctest $linter_targets
go test -tags rpctest $linter_targets

0 comments on commit 6487ba1

Please sign in to comment.