This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Add conversion for FloorDiv, ZerosLike and Fix bug in slice #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds model conversion for FloorDiv, ZerosLike Also fixes a bug in slice conversion. When the begin index is less than zero, the end index cannot be calculated by adding size. eg: begin = -1 and size = 1, will give end index = 0 which is incorrect. The end should be int max in such cases. Changes to be committed: modified: keras2onnx/_builtin.py
|
|
jiafatom
reviewed
Apr 15, 2020
|
Thanks for the contribution, it would be nicer to have some unit test, we have some example like test_tf_xxxx in test_layers.py for your reference to add an unit test. |
wenbingl
approved these changes
Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds model conversion for FloorDiv, ZerosLike
Also fixes a bug in slice conversion. When the begin index is
less than zero, the end index cannot be calculated by adding size.
eg: begin = -1 and size = 1, will give end index = 0 which is incorrect.
The end should be int max in such cases.
Changes to be committed:
modified: keras2onnx/_builtin.py