CAT-1068: Ruby client library generator #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoPetteruti-Onfido
force-pushed
the
feature/cat-1068-ruby-lib
branch
2 times, most recently
from
600af93
to
3e4c1d6
Compare
RiccardoPetteruti-Onfido
force-pushed
the
feature/cat-1068-ruby-lib
branch
2 times, most recently
from
87d0f38
to
6cdf06f
Compare
RiccardoPetteruti-Onfido
force-pushed
the
feature/cat-1068-ruby-lib
branch
from
6cdf06f
to
734c37a
Compare
RiccardoPetteruti-Onfido
changed the title
RiccardoPetteruti-Onfido
force-pushed
the
feature/cat-1068-ruby-lib
branch
from
23366fc
to
4f90204
Compare
| preCommit: | | ||
| bundle lock --update | ||
| version: ${{ needs.generate_specs_and_libraries.outputs.ruby_version }} | ||
| update: ${{ inputs.update-onfido-ruby || true}} |
There was a problem hiding this comment.
This || true should remain here only while testing CI
There was a problem hiding this comment.
i've removed it.
There was a problem hiding this comment.
It looks it's still there... 🤔
There was a problem hiding this comment.
forgot to add the file, removed now.
| else | ||
| render status: 498, text: "498 Token expired/invalid" | ||
| end | ||
| event = verifier.read_payload('{"payload":{"r...3"}}', signature) | ||
| ``` |
There was a problem hiding this comment.
Let's include also here the try-catch block with exception thrown when webhook signature is invalid, so user immediately see how to use this feature.
EDIT: Looking at the code added in webhook_event_verifier.mustache, the exception OnfidoInvalidSignatureError should be raised.
There was a problem hiding this comment.
added
RiccardoPetteruti-Onfido
force-pushed
the
feature/cat-1068-ruby-lib
branch
3 times, most recently
from
b3de635
to
d83dcb3
Compare
RiccardoPetteruti-Onfido
force-pushed
the
feature/cat-1068-ruby-lib
branch
from
d83dcb3
to
c656761
Compare
dvacca-onfido
approved these changes
May 3, 2024
DavidMealha-Onfido
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.