Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core dns #1487

Closed
wants to merge 5 commits into from
Closed

Remove core dns #1487

wants to merge 5 commits into from

Conversation

ajaykumar4
Copy link
Contributor

@ajaykumar4 ajaykumar4 commented May 22, 2024

By default coredns is enable in talos 1.7.2, we can remove this from helmfile
when install coredns using helmfile

Release "coredns" does not exist. Installing it now.
  Error: Unable to continue with install: ServiceAccount "coredns" in namespace "kube-system" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "coredns"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "kube-system"
 STDERR:
  Error: Unable to continue with install: Deployment "coredns" in namespace "kube-system" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "coredns"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "kube-system"
  and more error

solution for this

repositories:
  - name: cilium
    url: https://helm.cilium.io
  - name: postfinance
    url: https://postfinance.github.io/kubelet-csr-approver
  - name: coredns
    url: https://coredns.github.io/helm

helmDefaults:
  wait: true
  waitForJobs: true
  timeout: 600
  force: true

releases:
  - name: prometheus-operator-crds
    namespace: observability
    chart: oci://ghcr.io/prometheus-community/charts/prometheus-operator-crds
    version: 11.0.0
  - name: cilium
    namespace: kube-system
    chart: cilium/cilium
    version: 1.15.5
    values: ["../../apps/kube-system/cilium/app/helm-values.yaml"]
    needs: ["observability/prometheus-operator-crds"]
  - name: coredns
    namespace: kube-system
    chart: coredns/coredns
    version: 1.29.0
    values: ["../../apps/kube-system/coredns/app/helm-values.yaml"]
    needs: ["observability/prometheus-operator-crds", "cilium"]
    hooks:
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "annotate"
        - "serviceaccount"
        - "coredns"
        - "-n"
        - "kube-system"
        - "meta.helm.sh/release-name=coredns"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "annotate"
        - "serviceaccount"
        - "coredns"
        - "-n"
        - "kube-system"
        - "meta.helm.sh/release-namespace=kube-system"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "label"
        - "serviceaccount"
        - "coredns"
        - "-n"
        - "kube-system"
        - "app.kubernetes.io/managed-by=Helm"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "annotate"
        - "deployment"
        - "coredns"
        - "-n"
        - "kube-system"
        - "meta.helm.sh/release-name=coredns"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "annotate"
        - "deployment"
        - "coredns"
        - "-n"
        - "kube-system"
        - "meta.helm.sh/release-namespace=kube-system"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "label"
        - "deployment"
        - "coredns"
        - "-n"
        - "kube-system"
        - "app.kubernetes.io/managed-by=Helm"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "annotate"
        - "configmap"
        - "coredns"
        - "-n"
        - "kube-system"
        - "meta.helm.sh/release-name=coredns"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "annotate"
        - "configmap"
        - "coredns"
        - "-n"
        - "kube-system"
        - "meta.helm.sh/release-namespace=kube-system"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "label"
        - "configmap"
        - "coredns"
        - "-n"
        - "kube-system"
        - "app.kubernetes.io/managed-by=Helm"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "annotate"
        - "service"
        - "kube-dns"
        - "-n"
        - "kube-system"
        - "meta.helm.sh/release-name=coredns"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "annotate"
        - "service"
        - "kube-dns"
        - "-n"
        - "kube-system"
        - "meta.helm.sh/release-namespace=kube-system"
        - "--overwrite"
    - events: ["prepare"]
      command: "kubectl"
      args:
        - "label"
        - "service"
        - "kube-dns"
        - "-n"
        - "kube-system"
        - "app.kubernetes.io/managed-by=Helm"
        - "--overwrite"
  - name: kubelet-csr-approver
    namespace: kube-system
    chart: postfinance/kubelet-csr-approver
    version: 1.2.1
    values: ["../../apps/kube-system/kubelet-csr-approver/app/helm-values.yaml"]
    needs: ["observability/prometheus-operator-crds", "cilium", "coredns"]
  - name: spegel
    namespace: kube-system
    chart: oci://ghcr.io/spegel-org/helm-charts/spegel
    version: v0.0.22
    values: ["../../apps/kube-system/spegel/app/helm-values.yaml"]
    needs: ["observability/prometheus-operator-crds", "cilium", "coredns", "kubelet-csr-approver"]

@github-actions github-actions bot added the area/bootstrap Changes made in the bootstrap directory label May 22, 2024
@onedr0p
Copy link
Owner

onedr0p commented May 22, 2024

Fixed in 7dee32b

@onedr0p onedr0p closed this May 22, 2024
@ajaykumar4 ajaykumar4 deleted the remove-coreDns branch May 22, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Changes made in the bootstrap directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants