Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Bump project version 0.2.0 -> 0.5.0 #537

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

hjabird
Copy link
Contributor

@hjabird hjabird commented Jul 15, 2024

Description

  • Bump version given in CMake to match the next version to be released.

Fixes #536

Checklist

All Submissions

  • [N/A] Do all unit tests pass locally? Attach a log.
  • [N/A] Have you formatted the code using clang-format?

* Bump version given in CMake to match the next version to be released.
@hjabird
Copy link
Contributor Author

hjabird commented Jul 15, 2024

It is not clear to me what the version should be inbetween releases. I've chosen 0.5.0 since it means no further PRs are needed for the next source release.

@hjabird hjabird requested a review from mkrainiuk July 15, 2024 13:27
@Rbiessy
Copy link
Contributor

Rbiessy commented Jul 15, 2024

Pinging @toxicscum since he is taking care of the releases.

@mkrainiuk mkrainiuk requested a review from itopinsk July 15, 2024 17:54
@toxicscum
Copy link

Hi, we plan to update version 0.4 -> 0.5 in two weeks. Can we update this PR with 0.4 so far or postpone its merge till the version bump?

@hjabird
Copy link
Contributor Author

hjabird commented Jul 16, 2024

Can we update this PR with 0.4 so far or postpone its merge till the version bump?

It is probably easiest to prospone merging this for a bit. I'm not aware of anyone depending on the correct value of this at the moment.

@dnhsieh-intel
Copy link
Contributor

We actually have another place about version

release = '0.1'

The version is visible in the old documentation theme, but I didn't find the version appearing in the current documentation.

@toxicscum
Copy link

Hi @hjabird,
v0.5 published. Could you merge this now?

@hjabird
Copy link
Contributor Author

hjabird commented Aug 9, 2024

It needs a second approval first!

@hjabird hjabird merged commit 07c0b46 into oneapi-src:develop Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CMake] Project version does not match release tag
5 participants